[
https://issues.apache.org/jira/browse/IMPALA-9571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074699#comment-17074699
]
ASF subversion and git services commented on IMPALA-9571:
---------------------------------------------------------
Commit 76061331781e67b90d7750abadfaf8b013dc64a5 in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=7606133 ]
IMPALA-9571: Fix Impala crash from unexpected boost filesystem_error exception
The no-exception signature of boost::filesystem::remove_all() has a
longstanding bug where it can throw an exception even for the
no-exceptions interface. Boost recently added the "noexcept" specifier
to the no-exception signature of remove_all(). When a "noexcept"
function throws an exception, it causes the program to call std::terminate()
which aborts the program. This makes the try/catch block around
remove_all() useless.
As a point fix, this switches FilesystemUtil to use the remove_all()
signature that can throw exceptions. This code already had a try/catch
block around remove_all(), so now it just uses that to get the error
code.
Newer versions of boost (1.63+) fix the underlying problem, so this
code can be removed when we upgrade boost.
Testing:
- Ran core tests
- Ran FilesystemUtil backend test
Change-Id: I23016f37401604fc41fc99c0a056439a31333e3f
Reviewed-on: http://gerrit.cloudera.org:8080/15640
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Csaba Ringhofer <[email protected]>
> Impala fails to start up due to exception from boost::filesystem::remove_all()
> ------------------------------------------------------------------------------
>
> Key: IMPALA-9571
> URL: https://issues.apache.org/jira/browse/IMPALA-9571
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 4.0, Impala 3.4.0
> Reporter: Yongzhi Chen
> Assignee: Joe McDonnell
> Priority: Blocker
> Labels: broken-build, flaky
>
> In impala-asf-master-exhaustive-data-cache build,
> custom_cluster.test_local_catalog.TestCompactCatalogUpdates.test_restart_catalogd
> test failed:
> Error Message
> test setup failure
> Stacktrace
> common/custom_cluster_test_suite.py:190: in setup_method
> self._start_impala_cluster(cluster_args, **kwargs)
> common/custom_cluster_test_suite.py:307: in _start_impala_cluster
> check_call(cmd + options, close_fds=True)
> /usr/lib64/python2.7/subprocess.py:542: in check_call
> raise CalledProcessError(retcode, cmd)
> E CalledProcessError: Command
> '['/data/jenkins/workspace/impala-asf-master-exhaustive-data-cache/repos/Impala/bin/start-impala-cluster.py',
> '--state_store_args=--statestore_update_frequency_ms=50
> --statestore_priority_update_frequency_ms=50
> --statestore_heartbeat_frequency_ms=50', '--cluster_size=3',
> '--num_coordinators=3',
> '--log_dir=/data/jenkins/workspace/impala-asf-master-exhaustive-data-cache/repos/Impala/logs/custom_cluster_tests',
> '--log_level=1', '--impalad_args=--use_local_catalog=true ',
> '--state_store_args=None ', '--catalogd_args=--catalog_topic_mode=minimal ',
> '--impalad_args=--default_query_options=']' returned non-zero exit status 1
> .....
> 11:08:37 MainThread: Error starting cluster
> Traceback (most recent call last):
> File
> "/data/jenkins/workspace/impala-asf-master-exhaustive-data-cache/repos/Impala/bin/start-impala-cluster.py",
> line 770, in <module>
> expected_cluster_size - expected_catalog_delays)
> File
> "/data/jenkins/workspace/impala-asf-master-exhaustive-data-cache/repos/Impala/tests/common/impala_cluster.py",
> line 186, in wait_until_ready
> early_abort_fn=check_processes_still_running)
> File
> "/data/jenkins/workspace/impala-asf-master-exhaustive-data-cache/repos/Impala/tests/common/impala_service.py",
> line 267, in wait_for_num_known_live_backends
> early_abort_fn()
> File
> "/data/jenkins/workspace/impala-asf-master-exhaustive-data-cache/repos/Impala/tests/common/impala_cluster.py",
> line 178, in check_processes_still_running
> assert len(self.impalads) >= expected_num_impalads
> AssertionError
> DEBUG:impala_cluster:Found 2 impalad/1 statestored/1 catalogd process(es)
> Details:
> https://master-02.jenkins.cloudera.com/job/impala-asf-master-exhaustive-data-cache/113/testReport/custom_cluster.test_local_catalog/TestCompactCatalogUpdates/test_restart_catalogd/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
