[
https://issues.apache.org/jira/browse/IMPALA-9668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090182#comment-17090182
]
ASF subversion and git services commented on IMPALA-9668:
---------------------------------------------------------
Commit b921d982b530d4546efeb10ceb02c82297859da9 in impala's branch
refs/heads/master from Laszlo Gaal
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b921d98 ]
IMPALA-9668: Obey SKIP_TOOLCHAIN_BOOTSTRAP during virtualenv bootstrap
IMPALA-9626 broke the use case where the toolchain binaries are not
downloaded from the native-toolchain S3 bucket, because
SKIP_TOOLCHAIN_BOOTSTRAP is set to true.
Fix this use case by checking SKIP_TOOLCHAIN_BOOTSTRAP in
bin/bootstrap_environment.py:
- if true: just check if the specified version of the Python binary is
present at the expected toolchain location. If it is there, use it,
otherwise throw an exception and abort the bootstrap process.
- in any other case: proceed to download the Python binary as in
bootstrap_toolchain.py.
Test:
- simulate the custom toolchain setup by downloading the toolchain
binaries from the S3 bucket, copying them to a separate directory,
symlinking them into Impala/toolchain, then executing buildall.sh
with SKIP_BOOTSTRAP_TOOLCHAIN set to "true".
Change-Id: Ic51b3c327b3cebc08edff90de931d07e35e0c319
Reviewed-on: http://gerrit.cloudera.org:8080/15759
Reviewed-by: Laszlo Gaal <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> OSError: Cannot call rmtree on a symbolic link when creating python virtualenv
> ------------------------------------------------------------------------------
>
> Key: IMPALA-9668
> URL: https://issues.apache.org/jira/browse/IMPALA-9668
> Project: IMPALA
> Issue Type: Sub-task
> Reporter: huangtianhua
> Assignee: Laszlo Gaal
> Priority: Major
>
> I build impala on aarch64 and use cloudera/native-toolchain according
> https://cwiki.apache.org/confluence/display/IMPALA/Building+native-toolchain+from+scratch+and+using+with+Impala,
> then an error raised:
> INFO:bootstrap_virtualenv:Creating python virtualenv
> INFO:root:Removing existing package directory
> /home/jenkins/impala/toolchain/python-2.7.16
> Traceback (most recent call last):
> File "/home/jenkins/impala/bin/../infra/python/bootstrap_virtualenv.py",
> line 399, in <module>
> setup_virtualenv_if_not_exists()
> File "/home/jenkins/impala/bin/../infra/python/bootstrap_virtualenv.py",
> line 373, in setup_virtualenv_if_not_exists
> create_virtualenv()
> File "/home/jenkins/impala/bin/../infra/python/bootstrap_virtualenv.py",
> line 89, in create_virtualenv
> python_cmd = download_toolchain_python()
> File "/home/jenkins/impala/bin/../infra/python/bootstrap_virtualenv.py",
> line 206, in download_toolchain_python
> package.download()
> File "/home/jenkins/impala/bin/bootstrap_toolchain.py", line 295, in
> download
> shutil.rmtree(unpack_dir)
> File "/usr/lib/python2.7/shutil.py", line 255, in rmtree
> onerror(os.path.islink, path, sys.exc_info())
> File "/usr/lib/python2.7/shutil.py", line 253, in rmtree
> raise OSError("Cannot call rmtree on a symbolic link")
> {color:red}OSError: Cannot call rmtree on a symbolic link{color}
> ERROR in /home/jenkins/impala/bin/impala-python at line 31:
> Generated:
> /home/jenkins/impala/logs/extra_junit_xml_logs/generate_junitxml.buildall.impala-python.20200417_08_14_56.xml
> I found the error introduced by IMPALA-9626, it try to delete a link path, I
> think it should be error on x86 too? The second problem of IMPALA-9626 is
> that the python package on s3 built only for x86, it doesn't works for
> aarch64, right?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
