[
https://issues.apache.org/jira/browse/IMPALA-9701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094625#comment-17094625
]
ASF subversion and git services commented on IMPALA-9701:
---------------------------------------------------------
Commit f4258b5f971f90390b93aa7a2e76dd0b8a1d8825 in impala's branch
refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f4258b5 ]
IMPALA-9701: fix data race in BTS
A benign data race in BufferedTupleStream was flagged
by TSAN.
Testing:
Reran the unit test under TSAN, it succeeded.
Change-Id: Ie2c4464adbc51bb8b0214ba0adbfa71217b87c86
Reviewed-on: http://gerrit.cloudera.org:8080/15826
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> data race detected in ConcurrentReaders test in TSAN build
> -----------------------------------------------------------
>
> Key: IMPALA-9701
> URL: https://issues.apache.org/jira/browse/IMPALA-9701
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 4.0
> Reporter: Bikramjeet Vig
> Assignee: Tim Armstrong
> Priority: Blocker
>
> {noformat}
> 18:02:55 [ RUN ] SimpleTupleStreamTest.ConcurrentReaders
> 18:02:55 ==================
> 18:02:55 WARNING: ThreadSanitizer: data race (pid=14982)
> 18:02:55 Write of size 1 at 0x7ffe9ff40809 by main thread:
> 18:02:55 #0 impala::BufferedTupleStream::ReadIterator::Init(bool)
> /data/jenkins/workspace/impala-asf-master-core-tsan/repos/Impala/be/src/runtime/buffered-tuple-stream.cc:1082:19
> (buffered-tuple-stream-test+0x1d8dcc1)
> 18:02:55 #1 impala::BufferedTupleStream::PrepareForReadInternal(bool,
> impala::BufferedTupleStream::ReadIterator*)
> /data/jenkins/workspace/impala-asf-master-core-tsan/repos/Impala/be/src/runtime/buffered-tuple-stream.cc:596:14
> (buffered-tuple-stream-test+0x1d8b4a5)
> 18:02:55 #2 impala::BufferedTupleStream::PrepareForRead(bool, bool*)
> /data/jenkins/workspace/impala-asf-master-core-tsan/repos/Impala/be/src/runtime/buffered-tuple-stream.cc:581:10
> (buffered-tuple-stream-test+0x1d8dad5)
> 18:02:55 #3
> impala::SimpleTupleStreamTest_ConcurrentReaders_Test::TestBody()
> /data/jenkins/workspace/impala-asf-master-core-tsan/repos/Impala/be/src/runtime/buffered-tuple-stream-test.cc:1441:5
> (buffered-tuple-stream-test+0x19f29b6)
> 18:02:55 #4 void
> testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,
> void>(testing::Test*, void (testing::Test::*)(), char const*) <null>
> (buffered-tuple-stream-test+0x431ed62)
> 18:02:55 #5 __libc_start_main <null> (libc.so.6+0x21c04)
> 18:02:55
> 18:02:55 Previous read of size 1 at 0x7ffe9ff40809 by thread T300:
> 18:02:55 #0
> impala::BufferedTupleStream::CheckConsistencyFast(impala::BufferedTupleStream::ReadIterator
> const&) const
> /data/jenkins/workspace/impala-asf-master-core-tsan/repos/Impala/be/src/runtime/buffered-tuple-stream.cc:131:3
> (buffered-tuple-stream-test+0x1d89504)
> 18:02:55 #1
> impala::BufferedTupleStream::NextReadPage(impala::BufferedTupleStream::ReadIterator*)
>
> /data/jenkins/workspace/impala-asf-master-core-tsan/repos/Impala/be/src/runtime/buffered-tuple-stream.cc:541:3
> (buffered-tuple-stream-test+0x1d8d188)
> 18:02:55 #2 impala::Status
> impala::BufferedTupleStream::GetNextInternal<false,
> false>(impala::BufferedTupleStream::ReadIterator*, impala::RowBatch*, bool*,
> std::vector<unsigned char*, std::allocator<unsigned char*> >*)
> /data/jenkins/workspace/impala-asf-master-core-tsan/repos/Impala/be/src/runtime/buffered-tuple-stream.cc:741:5
> (buffered-tuple-stream-test+0x1d95100)
> 18:02:55 #3 impala::Status
> impala::BufferedTupleStream::GetNextInternal<false>(impala::BufferedTupleStream::ReadIterator*,
> impala::RowBatch*, bool*, std::vector<unsigned char*,
> std::allocator<unsigned char*> >*)
> /data/jenkins/workspace/impala-asf-master-core-tsan/repos/Impala/be/src/runtime/buffered-tuple-stream.cc:712:12
> (buffered-tuple-stream-test+0x1d907c1)
> 18:02:55 #4
> impala::BufferedTupleStream::GetNext(impala::BufferedTupleStream::ReadIterator*,
> impala::RowBatch*, bool*)
> /data/jenkins/workspace/impala-asf-master-core-tsan/repos/Impala/be/src/runtime/buffered-tuple-stream.cc:698:10
> (buffered-tuple-stream-test+0x1d8e1e0)
> 18:02:55 #5 void
> impala::SimpleTupleStreamTest::ReadValues<int>(impala::BufferedTupleStream*,
> impala::BufferedTupleStream::ReadIterator*, impala::RowDescriptor*,
> std::vector<int, std::allocator<int> >*, int)
> /data/jenkins/workspace/impala-asf-master-core-tsan/repos/Impala/be/src/runtime/buffered-tuple-stream-test.cc:279:9
> (buffered-tuple-stream-test+0x1a168d3)
> 18:02:55 #6
> impala::SimpleTupleStreamTest_ConcurrentReaders_Test::TestBody()::$_0::operator()()
> const
> /data/jenkins/workspace/impala-asf-master-core-tsan/repos/Impala/be/src/runtime/buffered-tuple-stream-test.cc:1431:9
> (buffered-tuple-stream-test+0x19f943c)
> 18:02:55 #7
> boost::detail::thread_data<impala::SimpleTupleStreamTest_ConcurrentReaders_Test::TestBody()::$_0>::run()
>
> /data/jenkins/workspace/impala-asf-master-core-tsan/Impala-Toolchain/boost-1.61.0-p2/include/boost/thread/detail/thread.hpp:116:17
> (buffered-tuple-stream-test+0x19f9250)
> 18:02:55 #8 thread_proxy <null> (buffered-tuple-stream-test+0x3138229)
> 18:02:55
> 18:02:55 Location is stack of main thread.
> 18:02:55
> 18:02:55 Thread T300 (tid=20013, running) created by main thread at:
> 18:02:55 #0 pthread_create
> /mnt/source/llvm/llvm-5.0.1.src-p2/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:889
> (buffered-tuple-stream-test+0x1976c8b)
> 18:02:55 #1 boost::thread::start_thread_noexcept() <null>
> (buffered-tuple-stream-test+0x31375b9)
> 18:02:55 #2
> boost::thread::thread<impala::SimpleTupleStreamTest_ConcurrentReaders_Test::TestBody()::$_0>(impala::SimpleTupleStreamTest_ConcurrentReaders_Test::TestBody()::$_0&&)
>
> /data/jenkins/workspace/impala-asf-master-core-tsan/Impala-Toolchain/boost-1.61.0-p2/include/boost/thread/detail/thread.hpp:265:13
> (buffered-tuple-stream-test+0x19f30a7)
> 18:02:55 #3
> impala::SimpleTupleStreamTest_ConcurrentReaders_Test::TestBody()
> /data/jenkins/workspace/impala-asf-master-core-tsan/repos/Impala/be/src/runtime/buffered-tuple-stream-test.cc:1424:28
> (buffered-tuple-stream-test+0x19f296d)
> 18:02:55 #4 void
> testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,
> void>(testing::Test*, void (testing::Test::*)(), char const*) <null>
> (buffered-tuple-stream-test+0x431ed62)
> 18:02:55 #5 __libc_start_main <null> (libc.so.6+0x21c04)
> 18:02:55
> 18:02:55 SUMMARY: ThreadSanitizer: data race
> /data/jenkins/workspace/impala-asf-master-core-tsan/repos/Impala/be/src/runtime/buffered-tuple-stream.cc:1082:19
> in impala::BufferedTupleStream::ReadIterator::Init(bool)
> 18:02:55 ==================
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
