[
https://issues.apache.org/jira/browse/IMPALA-9721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099598#comment-17099598
]
ASF subversion and git services commented on IMPALA-9721:
---------------------------------------------------------
Commit 6e0085c2207e9102b705778efe8e2698f1288ac0 in impala's branch
refs/heads/master from David Knupp
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=6e0085c ]
IMPALA-9721: Fix minor python2/3 syntax regression
A minor syntax error slipped past in a recent patch. In python3, the
syntax for catching exceptions requires the 'as' keyword. This error
was missed in code review.
Until automated python3 testing set up, this kind of error is likely
to repeat. See IMPALA-9724.
Change-Id: I0d36c609a3600c8084efcce0026537227144b27d
Reviewed-on: http://gerrit.cloudera.org:8080/15856
Reviewed-by: Tim Armstrong <[email protected]>
Tested-by: David Knupp <[email protected]>
> Fix python 3 compatibility regression in impala-shell
> -----------------------------------------------------
>
> Key: IMPALA-9721
> URL: https://issues.apache.org/jira/browse/IMPALA-9721
> Project: IMPALA
> Issue Type: Bug
> Components: Clients
> Reporter: David Knupp
> Assignee: David Knupp
> Priority: Major
>
> The fix for IMPALA-9398 introduced a small regression with regard to python 3
> compatibility. We don't have python 3 tests yet to catch regression of this
> this type, and it was missed in code review.
> The regression happens in two places. An example is:
> https://github.com/apache/impala/blob/master/shell/impala_shell.py#L248
> The syntax for catching exceptions has changed in python 3 to require the
> "as" keyword.
> {noformat}
> try:
> do_stuff()
> except <exception> as e:
> panic()
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
