[
https://issues.apache.org/jira/browse/IMPALA-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102128#comment-17102128
]
ASF subversion and git services commented on IMPALA-9729:
---------------------------------------------------------
Commit f4f7fb53a48f114f520737af7be2433a5afd03d4 in impala's branch
refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f4f7fb5 ]
IMPALA-9729: consistent GetExecSummary() behaviour
Before IMPALA-9380, GetExecSummary() for archived
queries without a coordinator returned a blank TExecSummary,
but for in-flight queries it returned a "not found" error.
This was masked by the synchronous query unregistration,
but now has made an impala-shell test flaky, because the
close() RPC returns to the shell before the query is archived,
so the following GetExecSummary() call may go down either
code path.
This change makes the behaviour consistent for both code
paths and preserves impala-shell behaviour.
Testing:
Looped TestImpalaShell.test_summary to make sure flakiness was
fixed.
Change-Id: If2b2ab118c4769e80284b2a3390577dd5f5e888b
Reviewed-on: http://gerrit.cloudera.org:8080/15868
Reviewed-by: Thomas Tauber-Marshall <[email protected]>
Tested-by: Tim Armstrong <[email protected]>
> TestImpalaShell.test_summary fails with Could not execute command: summary
> --------------------------------------------------------------------------
>
> Key: IMPALA-9729
> URL: https://issues.apache.org/jira/browse/IMPALA-9729
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Major
> Labels: flaky
> Fix For: Impala 4.0
>
>
> https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/2305/testReport/shell.test_shell_commandline/TestImpalaShell/test_summary_table_format_and_file_extension____textfile_____txt_____protocol__hs2_/
> {noformat}
> shell/test_shell_commandline.py:345: in test_summary result_set =
> run_impala_shell_cmd(vector, args) shell/util.py:172: in run_impala_shell_cmd
> result.stderr) E AssertionError: Cmd ['-q', 'show tables; summary;']
> was expected to succeed: Server version: impalad version 4.0.0-SNAPSHOT DEBUG
> (build c92321c20c7956f6a5dd947de7fe867052aca0fe) E Query: show tables E
> Fetched 3 row(s) in 0.03s E ERROR: Query id
> 924e3b59eb41ff48:078cff2f00000000 not found. E E Could not execute
> command: summary
> Stacktrace
> shell/test_shell_commandline.py:345: in test_summary
> result_set = run_impala_shell_cmd(vector, args)
> shell/util.py:172: in run_impala_shell_cmd
> result.stderr)
> E AssertionError: Cmd ['-q', 'show tables; summary;'] was expected to
> succeed: Server version: impalad version 4.0.0-SNAPSHOT DEBUG (build
> c92321c20c7956f6a5dd947de7fe867052aca0fe)
> E Query: show tables
> E Fetched 3 row(s) in 0.03s
> E ERROR: Query id 924e3b59eb41ff48:078cff2f00000000 not found.
> E
> E Could not execute command: summary
> {noformat}
> I can reproduce locally.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
