[ 
https://issues.apache.org/jira/browse/IMPALA-9722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Mate resolved IMPALA-9722.
--------------------------------
    Fix Version/s: Impala 4.0
       Resolution: Fixed

> Consolidate unused total_width and the way avg_width is computed in 
> PerColumnStats
> ----------------------------------------------------------------------------------
>
>                 Key: IMPALA-9722
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9722
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>            Reporter: Tamas Mate
>            Assignee: Tamas Mate
>            Priority: Major
>              Labels: statistics
>             Fix For: Impala 4.0
>
>
> PerColumnStats.total_width is an unused field in 
> [incr-stats-util.cc|https://github.com/apache/impala/blob/master/be/src/exec/incr-stats-util.cc#L134]
>  while the comment says that it is the result of {{(avg_width * num_rows)}}. 
> Later [similar 
> multiplication|https://github.com/apache/impala/blob/master/be/src/exec/incr-stats-util.cc#L159]
>  can be found in the Update method, however the result is stored in 
> {{avg_width}}.
> {code:cpp}
> avg_width += (new_avg_width * num_new_rows);
> {code}
> We should consolidate these fields and the calculations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to