[
https://issues.apache.org/jira/browse/IMPALA-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Armstrong updated IMPALA-6283:
----------------------------------
Priority: Minor (was: Major)
> False positive at Test* functions in expr-test.cc if a result is NULL
> ---------------------------------------------------------------------
>
> Key: IMPALA-6283
> URL: https://issues.apache.org/jira/browse/IMPALA-6283
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Reporter: Jin Chul Kim
> Priority: Minor
> Labels: newbie
>
> In be/src/exprs/expr-test.cc, some helper functions does not work
> unexpectedly.
> If expr returns NULL, the test should fail because NULL cannot be compared.
> If we expect NULL as a result, we should use TestIsNull.
> TestValue(expr, expr_type, expected_result)
> {noformat}
> TestValue("cast(null as int)", TYPE_INT, 0);
> TestStringValue("cast(null as string)", "NULL");
> {noformat}
> Please don't forget to add the above cases as unit tests to verify your patch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
