Tim Armstrong created IMPALA-9756:
-------------------------------------
Summary: Queries are not guaranteed to be cancelled before
unregistration
Key: IMPALA-9756
URL: https://issues.apache.org/jira/browse/IMPALA-9756
Project: IMPALA
Issue Type: Bug
Components: Backend
Reporter: Tim Armstrong
Assignee: Tim Armstrong
I noticed while running TSAN on a branch that it's possible for a query to be
unregistered *while* cancellation is in progress, if the cancellation is
triggered by a different thread (e.g. a separate client connection) and
This is because ClientRequestState::Cancel() will return early if cancellation
was already started, and ImpalaServer::Unregister() will proceed.
I think the main consequence of this is that the profile may be missing
information that is added during cancellation (ComputeQuerySummary(), etc), but
it generally makes the code more racy and bugs more likely.
Instead Finalize() should wait for the cancellation to finish in the other
thread before proceeding.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]