[
https://issues.apache.org/jira/browse/IMPALA-9760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120302#comment-17120302
]
ASF subversion and git services commented on IMPALA-9760:
---------------------------------------------------------
Commit 56ee90c598dcc637f10647ffc3e03cc0a70b92ce in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=56ee90c ]
IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7
The locations for native-toolchain packages in IMPALA_TOOLCHAIN
currently do not include the compiler version. This means that
the toolchain can't distinguish between native-toolchain packages
built with gcc 4.9.2 versus gcc 7.5.0. The collisions can cause
issues when switching back and forth between branches.
This introduces the IMPALA_TOOLCHAIN_PACKAGES_HOME environment
variable, which is a location inside IMPALA_TOOLCHAIN that would
hold native-toolchain packages. Currently, it is set to the same
as IMPALA_TOOLCHAIN, so there is no difference in behavior.
This lays the groundwork to add the compiler version to this
path when switching to GCC7.
Testing:
- The only impediment to building with
IMPALA_TOOLCHAIN_PACKAGES_HOME=$IMPALA_TOOLCHAIN/test is
Impala-lzo. With a custom Impala-lzo, compilation succeeds.
Either Impala-lzo will be fixed or it will be removed.
- Core tests
Change-Id: I1ff641e503b2161baf415355452f86b6c8bfb15b
Reviewed-on: http://gerrit.cloudera.org:8080/15991
Reviewed-by: Joe McDonnell <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Use different locations for native toolchain packages built with different
> compilers
> ------------------------------------------------------------------------------------
>
> Key: IMPALA-9760
> URL: https://issues.apache.org/jira/browse/IMPALA-9760
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: Impala 4.0
> Reporter: Joe McDonnell
> Priority: Minor
>
> To switch to GCC 7 with the new ABI, we want to keep the packages using the
> old ABI and new ABI separate. This means that they will need to reside in
> different directories inside IMPALA_TOOLCHAIN. There is code in other
> repositories that depends on finding things inside IMPALA_TOOLCHAIN, so it
> may be easiest to have multiple phases:
> 1. Introducing a new variable tracking the native package location which is
> the same as IMPALA_TOOLCHAIN
> 2. Switch dependent code to use this new variable
> 3. Change the value of the variable to be different for different compilers
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
