[
https://issues.apache.org/jira/browse/IMPALA-7538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129921#comment-17129921
]
Quanlong Huang commented on IMPALA-7538:
----------------------------------------
Nice find! I investigated the codes and found CatalogdMetaProvider already
tracks the removed objects in deletedObjectsLog_:
[https://github.com/apache/impala/blob/ad8f468871d3a893bf4c7b702025ec70765ce8e1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java#L1130-L1136]
Since HdfsCachePool is still a CatalogObject, we don't need additional cares on
it.
BTW, the CatalogDeltaLog(deletedObjectsLog_) in coordinator side is used to
avoid concurrent conflicts between direct updates from DDL and async updates
from statestored. No DDLs return a HdfsCachePool object since we don't have
DDLs for creating a cache pool. So it's ok even if we don't track removed
HdfsCachePool in coordinator's CatalogDeltaLog.
Anyway, since we already track all the removed catalog objects, we don't need
additional logics for it.
> Support HDFS caching with LocalCatalog
> --------------------------------------
>
> Key: IMPALA-7538
> URL: https://issues.apache.org/jira/browse/IMPALA-7538
> Project: IMPALA
> Issue Type: Sub-task
> Reporter: Todd Lipcon
> Assignee: Quanlong Huang
> Priority: Major
> Labels: catalog-v2
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
