[
https://issues.apache.org/jira/browse/IMPALA-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139012#comment-17139012
]
Quanlong Huang commented on IMPALA-9213:
----------------------------------------
Thanks for the pointers. I notice that impala-shell only calls get_log/GetLog
once when the query finishes or fails:
*
[https://github.com/apache/impala/blob/3088ca8580ed2f8c87235cbee3f3b3a90c292218/shell/impala_shell.py#L1160]
*
[https://github.com/apache/impala/blob/3088ca8580ed2f8c87235cbee3f3b3a90c292218/shell/impala_shell.py#L1182]
*
[https://github.com/apache/impala/blob/3088ca8580ed2f8c87235cbee3f3b3a90c292218/shell/impala_client.py#L243]
Haven't checked other clients yet. But I guess they use the same pattern as
impala-shell:
* Periodically calls get_summary() when the query is queuing or running.
Queuing reason, progress info and the live summary are returned in the result.
* Calls get_log() when the query finishes or fails. Print the log at the end.
So client won't print the new query id at once when the query is retried. We
can add this in the get_summary() results so new version of the clients can
make use of it. TExecSummary has a error_logs field in which we can add the
retry info.
For the link to the new query on the web UI, it's constructed by the client
using the query id and the hostname it connects to (could be a LB address). So
it's unsuitable to return the link in get_log() result. Once we return the new
query id in get_summary() as well, clients can construct the links.
I plan to modify get_summary() in IMPALA-9569 to also fix the progress bar
issue.
Uploaded patch for this JIRA: [https://gerrit.cloudera.org/c/16093/]
> Client logs should indicate if a query has been retried
> -------------------------------------------------------
>
> Key: IMPALA-9213
> URL: https://issues.apache.org/jira/browse/IMPALA-9213
> Project: IMPALA
> Issue Type: Sub-task
> Reporter: Sahil Takiar
> Assignee: Quanlong Huang
> Priority: Major
>
> The client logs should give some indication that a query has been retried and
> should print out information such as the new query id and the link to the
> retried query on the debug web UI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
