[
https://issues.apache.org/jira/browse/IMPALA-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168113#comment-17168113
]
ASF subversion and git services commented on IMPALA-10024:
----------------------------------------------------------
Commit a10ad2cad99a8a1b84b4faa23e28f2bad592db43 in impala's branch
refs/heads/master from Vihang Karajgaonkar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a10ad2c ]
IMPALA-10024: isBlackListedDb() should do a case-insensitive check
The util method CatalogServiceCatalog#isBlackListedDb() expects the
input dbName to be in lower-case which could be error-prone.
Specifically, this can cause issues when Metastore event which has
dbName which is in a different case than one configured in
--blacklisted_dbs. In such cases the EventsProcessor does not ignore
the event and can go into error state.
The fix modifies the isBlackListedDb method to do a case-insensitive
comparision. The isBlacklistedTable is not affected by this issue
since TableName has built-in mechanism to ignore the case.
Testing Done:
1. Modified the test_event_processing.py such that event generated
has a different case than what is configured in --blacklisted_dbs.
The updated test works after the patch.
2. Ran existing tests for events processor.
Change-Id: I3898a46b4236413b2e328cecbb2f4364082a5e41
Reviewed-on: http://gerrit.cloudera.org:8080/16254
Reviewed-by: Tim Armstrong <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> CatalogServiceCatalog.isBlacklistedDb should do a case-insensitive comparison
> -----------------------------------------------------------------------------
>
> Key: IMPALA-10024
> URL: https://issues.apache.org/jira/browse/IMPALA-10024
> Project: IMPALA
> Issue Type: Bug
> Reporter: Vihang Karajgaonkar
> Assignee: Vihang Karajgaonkar
> Priority: Major
>
> CatalogServiceCatalog.isBlacklistedDb() is used in many places to check if a
> given database name is on the list of databases which should be ignored in
> Catalog. However it does a case sensitive comparison which could cause false
> negatives.
> One place where we see this issue is when we receive a metastore event on the
> on {{SYS}} database and the {{--blacklisted_dbs}} is set to \{{sys}}. In such
> cases EventsProcessor should ignore the event instead of processing it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
