[
https://issues.apache.org/jira/browse/IMPALA-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe McDonnell resolved IMPALA-10044.
------------------------------------
Fix Version/s: Impala 4.0
Target Version: Impala 4.0
Assignee: Joe McDonnell
Resolution: Fixed
> bin/bootstrap_toolchain.py error handling can delete the toolchain directory
> ----------------------------------------------------------------------------
>
> Key: IMPALA-10044
> URL: https://issues.apache.org/jira/browse/IMPALA-10044
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: Impala 4.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
> Fix For: Impala 4.0
>
>
> In bin/bootstrap_toolchain.py's DownloadUnpackTarball download() function,
> the exception handler code will delete the download directory:
> {code:java}
> except: # noqa
> # Clean up any partially-unpacked result.
> if os.path.isdir(unpack_dir):
> shutil.rmtree(unpack_dir)
> if os.path.isdir(download_dir): # <---- wrong
> shutil.rmtree(download_dir)
> raise
> {code}
> This is incorrect. It should only delete the download directory if the
> download directory is a temporary directory. Otherwise, it would be deleting
> the actual toolchain directory (and forcing a redownload of everything).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
