[
https://issues.apache.org/jira/browse/IMPALA-7779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184746#comment-17184746
]
ASF subversion and git services commented on IMPALA-7779:
---------------------------------------------------------
Commit 2ebf554dfdb0dc9055ef95c8f2ec4fad51f1e657 in impala's branch
refs/heads/master from Qifan Chen
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=2ebf554 ]
IMPALA-7779 Parquet Scanner can write binary data into profile
This fix addresses the current limitation in that an ill-formatted
Parquet version string is not properly formatted before appearing
in an error message or impalad.INFO. With the fix, any such string is
converted to a hex string first. The hex string is a sequence of
four hex digit groups separated by spaces and each group is one or
two hex digits, such as "6c 65 2e a".
Testing:
Ran "core" tests successfully.
Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1
Reviewed-on: http://gerrit.cloudera.org:8080/16331
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Sahil Takiar <[email protected]>
> Parquet Scanner can write binary data into profile
> --------------------------------------------------
>
> Key: IMPALA-7779
> URL: https://issues.apache.org/jira/browse/IMPALA-7779
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 3.1.0
> Reporter: Lars Volker
> Assignee: Qifan Chen
> Priority: Major
> Labels: profile
>
> In
> [hdfs-parquet-scanner.cc:1224|https://github.com/apache/impala/blob/master/be/src/exec/hdfs-parquet-scanner.cc#L1224]
> we log an invalid file version string. Whatever 4 bytes that that pointer
> points to will end up in the profile. These can be non-ascii characters, thus
> potentially breaking tools that parse the profiles and expect their content
> to be plain text. We should either remove the bytes from the message, or
> escape them as hex.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
