[
https://issues.apache.org/jira/browse/IMPALA-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186679#comment-17186679
]
ASF subversion and git services commented on IMPALA-10092:
----------------------------------------------------------
Commit 34668fab878c224632710670618b3f0176cbc78d in impala's branch
refs/heads/master from Fang-Yu Rao
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=34668fa ]
IMPALA-10092: Do not skip test vectors of Kudu tests in a custom cluster
We found that the following 4 tests do not run even we remove all the
decorators like "@SkipIfKudu.no_hybrid_clock" or
"@SkipIfHive3.kudu_hms_notifications_not_supported" to skip the tests.
This is due to the fact that those 3 classes inherit the class of
CustomClusterTestSuite, which adds a constraint that only allows test
vectors with 'file_format' and 'compression_codec' being "text" and
"none", respectively, to be run.
1. TestKuduOperations::test_local_tz_conversion_ops
2. TestKuduClientTimeout::test_impalad_timeout
3. TestKuduHMSIntegration::test_create_managed_kudu_tables
4. TestKuduHMSIntegration::test_kudu_alter_table
To address this issue, in this patch we create a parent class for those
3 classes above and override the method of
add_custom_cluster_constraints() for this newly created parent class so
that we do not skip test vectors with 'file_format' and
'compression_codec' being "kudu" and "none", respectively.
On the other hand, this patch also removes a redundant method call to
super(CustomClusterTestSuite, cls).add_test_dimensions() in
CustomClusterTestSuite.add_custom_cluster_constraints() since
super(CustomClusterTestSuite, cls).add_test_dimensions() had
already been called immediately before the call to
add_custom_cluster_constraints() in
CustomClusterTestSuite.add_test_dimensions().
Testing:
- Manually verified that after removing the decorators to skip those
tests, those tests could be run.
Change-Id: I60a4bd4ac5a9026629fb840ab9cc7b5f9948290c
Reviewed-on: http://gerrit.cloudera.org:8080/16348
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Some tests in custom_cluster/test_kudu.py do not run even they are not
> explicitly disabled.
> -------------------------------------------------------------------------------------------
>
> Key: IMPALA-10092
> URL: https://issues.apache.org/jira/browse/IMPALA-10092
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Reporter: Fang-Yu Rao
> Assignee: Fang-Yu Rao
> Priority: Minor
> Labels: kudu, test
>
> We found that the following tests in
> https://github.com/apache/impala/blob/master/tests/custom_cluster/test_kudu.py
> do not run even we remove all the decorators like
> "{{@SkipIfKudu.no_hybrid_clock}}" or
> "{{@SkipIfHive3.kudu_hms_notifications_not_supported}}" to skip the tests.
> # {{TestKuduOperations::test_local_tz_conversion_ops}}
> # {{TestKuduClientTimeout::test_impalad_timeout}}
> # {{TestKuduHMSIntegration::test_create_managed_kudu_tables}}
> # {{TestKuduHMSIntegration::test_kudu_alter_table}}
> This may be due to the fact that we add at
> https://github.com/apache/impala/blob/master/tests/common/custom_cluster_test_suite.py#L78-L80
> a constraint that only allows '{{table_format}}' to be "{{text/none}}",
> i.e., '{{file_format}}' has to be "{{text}}" and '{{compression_codec}}' has
> to be "{{none}}". It can be verified that by removing this constraint, the
> tests above could be run after removing all the decorators with
> '{{table_format}}' being "{{kudu/none}}", which is added according to
> https://github.com/apache/impala/blob/master/tests/common/test_dimensions.py#L116-L119.
>
> In this regard, we may need to override the class method of
> add_test_dimensions() of the classes of {{TestKuduOperations}},
> {{TestKuduClientTimeout}}, and {{TestKuduHMSIntegration}} so that once those
> currently disabled Kudu tests are re-enabled, those tests involving the test
> vector could be run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
