[ https://issues.apache.org/jira/browse/IMPALA-10119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190442#comment-17190442 ]
ASF subversion and git services commented on IMPALA-10119: ---------------------------------------------------------- Commit 2359a1be9dc491f6c35fe3415265d4a29d6bc939 in impala's branch refs/heads/master from Tamas Mate [ https://gitbox.apache.org/repos/asf?p=impala.git;h=2359a1b ] IMPALA-10119: Fix impala-shell history duplication test The flaky test was TestImpalaShellInteractive.test_history_does_not_duplicate_on_interrupt The test failed with timeout error when the interrupt signal arrived later after the next test query was started. The impala-shell output was ^C instead of the expected query result. This change adds an additional blocking expect call to wait for the interrupt signal to arrive before sending in the next query. Change-Id: I242eb47cc8093c4566de206f46b75b3feab1183c Reviewed-on: http://gerrit.cloudera.org:8080/16391 Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> > TestImpalaShellInteractive.test_history_does_not_duplicate_on_interrupt > ----------------------------------------------------------------------- > > Key: IMPALA-10119 > URL: https://issues.apache.org/jira/browse/IMPALA-10119 > Project: IMPALA > Issue Type: Bug > Components: Infrastructure > Affects Versions: Impala 4.0 > Reporter: Tim Armstrong > Assignee: Tamas Mate > Priority: Critical > Labels: flaky > Fix For: Impala 4.0 > > > This test was flaky. > https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/3069/testReport/junit/shell.test_shell_interactive/TestImpalaShellInteractive/test_history_does_not_duplicate_on_interrupt_table_format_and_file_extension____textfile_____txt_____protocol__hs2_/ > {noformat} > shell.test_shell_interactive.TestImpalaShellInteractive.test_history_does_not_duplicate_on_interrupt[table_format_and_file_extension: > ('textfile', '.txt') | protocol: hs2] (from pytest) > Failing for the past 1 build (Since Failed#3069 ) > Took 36 sec. > Error Message > shell/test_shell_interactive.py:532: in > test_history_does_not_duplicate_on_interrupt child_proc.expect("Fetched 1 > row\(s\) in [0-9]+\.?[0-9]*s") > ../infra/python/env-gcc7.5.0/lib/python2.7/site-packages/pexpect/__init__.py:1451: > in expect timeout, searchwindowsize) > ../infra/python/env-gcc7.5.0/lib/python2.7/site-packages/pexpect/__init__.py:1466: > in expect_list timeout, searchwindowsize) > ../infra/python/env-gcc7.5.0/lib/python2.7/site-packages/pexpect/__init__.py:1568: > in expect_loop raise TIMEOUT(str(err) + '\n' + str(self)) E TIMEOUT: > Timeout exceeded. E <pexpect.spawn object at 0x7f2d51b997d0> E version: > 3.3 E command: > /home/ubuntu/Impala/shell/build/impala-shell-4.0.0-SNAPSHOT/impala-shell E > args: > ['/home/ubuntu/Impala/shell/build/impala-shell-4.0.0-SNAPSHOT/impala-shell', > '--protocol=hs2', '-ilocalhost:21050'] E searcher: <pexpect.searcher_re > object at 0x7f2d51b99a10> E buffer (last 100 chars): ' default> select > 2;\r\n^C\r\n[localhost:21050] default> ' E before (last 100 chars): ' > default> select 2;\r\n^C\r\n[localhost:21050] default> ' E after: <class > 'pexpect.TIMEOUT'> E match: None E match_index: None E exitstatus: None > E flag_eof: False E pid: 12993 E child_fd: 24 E closed: False E > timeout: 30 E delimiter: <class 'pexpect.EOF'> E logfile: None E > logfile_read: None E logfile_send: None E maxread: 2000 E ignorecase: > False E searchwindowsize: None E delaybeforesend: 0.05 E > delayafterclose: 0.1 E delayafterterminate: 0.1 > Stacktrace > shell/test_shell_interactive.py:532: in > test_history_does_not_duplicate_on_interrupt > child_proc.expect("Fetched 1 row\(s\) in [0-9]+\.?[0-9]*s") > ../infra/python/env-gcc7.5.0/lib/python2.7/site-packages/pexpect/__init__.py:1451: > in expect > timeout, searchwindowsize) > ../infra/python/env-gcc7.5.0/lib/python2.7/site-packages/pexpect/__init__.py:1466: > in expect_list > timeout, searchwindowsize) > ../infra/python/env-gcc7.5.0/lib/python2.7/site-packages/pexpect/__init__.py:1568: > in expect_loop > raise TIMEOUT(str(err) + '\n' + str(self)) > E TIMEOUT: Timeout exceeded. > E <pexpect.spawn object at 0x7f2d51b997d0> > E version: 3.3 > E command: > /home/ubuntu/Impala/shell/build/impala-shell-4.0.0-SNAPSHOT/impala-shell > E args: > ['/home/ubuntu/Impala/shell/build/impala-shell-4.0.0-SNAPSHOT/impala-shell', > '--protocol=hs2', '-ilocalhost:21050'] > E searcher: <pexpect.searcher_re object at 0x7f2d51b99a10> > E buffer (last 100 chars): ' default> select 2;\r\n^C\r\n[localhost:21050] > default> ' > E before (last 100 chars): ' default> select 2;\r\n^C\r\n[localhost:21050] > default> ' > E after: <class 'pexpect.TIMEOUT'> > E match: None > E match_index: None > E exitstatus: None > E flag_eof: False > E pid: 12993 > E child_fd: 24 > E closed: False > E timeout: 30 > E delimiter: <class 'pexpect.EOF'> > E logfile: None > E logfile_read: None > E logfile_send: None > E maxread: 2000 > E ignorecase: False > E searchwindowsize: None > E delaybeforesend: 0.05 > E delayafterclose: 0.1 > E delayafterterminate: 0.1 > {noformat} > The test was added in IMPALA-9398. > Looks like it's stuck in this line of code waiting for the fetched message: > {code} > child_proc.sendintr() > child_proc.sendline("select 2;") > child_proc.expect("Fetched 1 row\(s\) in [0-9]+\.?[0-9]*s") > child_proc.sendline("quit;") > child_proc.wait() > {code} > [~tmate] can you have a look? It wasn't immediately obvious to me what > happened, although maybe the interrupt was handled after the select 2 command > - I see ^C after select 2 in the output? -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org