[
https://issues.apache.org/jira/browse/IMPALA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214325#comment-17214325
]
ASF subversion and git services commented on IMPALA-10220:
----------------------------------------------------------
Commit c7581b5d8a9e00006a34cb82e88fa0ede26cfb3f in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=c7581b5 ]
IMPALA-10220: Fix negative value bug in RpcNetworkTime counter.
Total RPC time was incorrectly computed using
resp_.receiver_latency_ns() in function EndDataStreamCompleteCb(). This
patch fix the bug by replacing it with eos_rsp_.receiver_latency_ns().
This patch also fix logging mistakes in LogSlowRpc() to use its 'resp'
parameter instead of 'resp_' field member.
Testing:
- Manually run data loading query that exhibit the bug for several times
and verify that the Min value of RpcNetworkTime counter is always
positive after the patch. The query used in testing is insert query to
TPC-DS fact table store_sales of scale 10GB in single machine mini
cluster.
- Add DCHECK to verify that total rpc time is greater than or equal to
receiver_latency_ns.
- Run and pass core tests.
Change-Id: I2a4d65a3e0f88349bd4ee1b01290bd2c386acc69
Reviewed-on: http://gerrit.cloudera.org:8080/16552
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Min value of RpcNetworkTime can be negative
> -------------------------------------------
>
> Key: IMPALA-10220
> URL: https://issues.apache.org/jira/browse/IMPALA-10220
> Project: IMPALA
> Issue Type: Bug
> Components: Distributed Exec
> Affects Versions: Impala 3.4.0
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
>
> There is a bug in function
> KrpcDataStreamSender::Channel::EndDataStreamCompleteCb(), particularly in
> this line:
> [https://github.com/apache/impala/blob/d453d52/be/src/runtime/krpc-data-stream-sender.cc#L635]
> network_time_ns should be computed using eos_rsp_.receiver_latency_ns()
> instead of resp_.receiver_latency_ns().
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
