[
https://issues.apache.org/jira/browse/IMPALA-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217108#comment-17217108
]
ASF subversion and git services commented on IMPALA-10226:
----------------------------------------------------------
Commit e76010d62889aaa2b04f6cfea9bb74b829877eb9 in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=e76010d ]
IMPALA-10226: Change buildall.sh -notests to invoke a single Make target
This is a small cleanup to add specific targets in CMake for
buildall.sh -notests to invoke. Previously, it ran multiple
targets like:
make target1 target2 target3 ...
In hand tests, make builds each target separately, so it is
unable to overlap the builds of the multiple targets. Pushing
it into CMake simplifies the code and allows the targets to
build simultaneously.
Testing:
- Ran buildall.sh -notests
Change-Id: Id881d6f481b32ba82501b16bada14b6630ba32d2
Reviewed-on: http://gerrit.cloudera.org:8080/16605
Reviewed-by: Tim Armstrong <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Change buildall.sh -notests to invoke a single Make target
> ----------------------------------------------------------
>
> Key: IMPALA-10226
> URL: https://issues.apache.org/jira/browse/IMPALA-10226
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 4.0
> Reporter: Joe McDonnell
> Priority: Major
>
> Currently, running "buildall.sh -notests" boils down to invoking make with
> multiple targets:
>
> {noformat}
> if [[ $BUILD_TESTS -eq 0 ]]; then
> # Specify all the non-test targets
> MAKE_TARGETS="impalad statestored catalogd fesupport loggingsupport
> ImpalaUdf \
> udasample udfsample"
> if (( build_independent_targets )); then
> MAKE_TARGETS+=" cscope fe tarballs"
> fi
> fi
> ${MAKE_CMD} -j${IMPALA_BUILD_THREADS:-4} ${IMPALA_MAKE_FLAGS}
> ${MAKE_TARGETS}{noformat}
> Based on the build output, it looks like each make target is invoked
> individually (with the commands underneath going parallel). This is
> particularly a problem for impalad (which needs to build the backend) and fe.
> We want these to run simultaneously, and this limitation prevents that.
> We should create a single target that builds all the things needing to be
> built for -notests. Then, this will be invoking one target and allowing all
> the pieces go parallel.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
