[
https://issues.apache.org/jira/browse/IMPALA-10249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235163#comment-17235163
]
ASF subversion and git services commented on IMPALA-10249:
----------------------------------------------------------
Commit 47dbfde0b2cabd14452f18527e954aec5891224c in impala's branch
refs/heads/master from Andrew Sherman
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=47dbfde ]
IMPALA-10249: Fix the flaky TestImpalaShell.test_queries_closed test.
This test for IMPALA-897 is testing that queries run by Impala Shell
from a script file are closed correctly. This is tested by an assertion
that there is one in-flight query during execution of a script
containing several queries. The test then closes the shell and checks
that there are no in-flight queries. This is the assertion which failed.
Change this assertion to instead wait for the number of in-flight
queries to be zero. This avoids whatever race was causing the flakiness.
Change-Id: Ib0485097c34282523ed0df6faa143fee6f74676d
Reviewed-on: http://gerrit.cloudera.org:8080/16743
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> TestImpalaShell.test_queries_closed is flaky
> --------------------------------------------
>
> Key: IMPALA-10249
> URL: https://issues.apache.org/jira/browse/IMPALA-10249
> Project: IMPALA
> Issue Type: Bug
> Reporter: Quanlong Huang
> Assignee: Andrew Sherman
> Priority: Critical
> Labels: broken-build, flaky
>
> Saw a failure in a CORE ASAN build:
> shell.test_shell_commandline.TestImpalaShell.test_queries_closed[table_format_and_file_extension:
> ('textfile', '.txt') | protocol: hs2-http] (from pytest)
> {code:java}
> /data/jenkins/workspace/impala-cdpd-master-core-asan/repos/Impala/tests/shell/test_shell_commandline.py:365:
> in test_queries_closed
> assert 0 == impalad_service.get_num_in_flight_queries()
> E assert 0 == 1
> E + where 1 = <bound method ImpaladService.get_num_in_flight_queries of
> <tests.common.impala_service.ImpaladService object at 0x7ac8510>>()
> E + where <bound method ImpaladService.get_num_in_flight_queries of
> <tests.common.impala_service.ImpaladService object at 0x7ac8510>> =
> <tests.common.impala_service.ImpaladService object at
> 0x7ac8510>.get_num_in_flight_queries {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
