[
https://issues.apache.org/jira/browse/IMPALA-10333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17237314#comment-17237314
]
ASF subversion and git services commented on IMPALA-10333:
----------------------------------------------------------
Commit cc8ecd0926633133dc2db291ac65c317da34bad7 in impala's branch
refs/heads/master from stiga-huang
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=cc8ecd0 ]
IMPALA-10333: Fix utf-8 test failures when impala-shell using older thrift
versions
In some branches that impala-shell still uses older version of thrift,
e.g. thrift-0.9.3-p8, test_utf8_decoding_error_handling will fail since
the internal string representation of thrift versions lower than 0.10.0
is still bytes. Strings won't be decoded to unicodes so there won't be
any decoding errors. The test expects some bytes that can't be decoded
correctly be replaced with U+FFFD so fails.
This patch improve the test by also expecting results from older thrift
versions. So it can be cherry-picked to older branches.
Tests:
- Verify the test in master branch and a downstream branch that still
uses thrift-0.9.3-p8 in impala-shell.
Change-Id: Ieb0baa9b3a1480673af77f7cc35c05eacf4b449f
Reviewed-on: http://gerrit.cloudera.org:8080/16767
Reviewed-by: Tim Armstrong <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> shell.test_shell_commandline.TestImpalaShell.test_utf8_decoding_error_handling
> failing
> --------------------------------------------------------------------------------------
>
> Key: IMPALA-10333
> URL: https://issues.apache.org/jira/browse/IMPALA-10333
> Project: IMPALA
> Issue Type: Bug
> Components: Clients
> Reporter: Tim Armstrong
> Assignee: Quanlong Huang
> Priority: Blocker
> Labels: broken-build
>
> I'm seeing a failure on an internal Centos7 build in
> shell.test_shell_commandline.TestImpalaShell.test_utf8_decoding_error_handling
> This was added in IMPALA-10145
> {noformat}
> Failed
> shell.test_shell_commandline.TestImpalaShell.test_utf8_decoding_error_handling[table_format_and_file_extension:
> ('parquet', '.parq') | protocol: beeswax] (from pytest)
> Failing for the past 7 builds (Since Failed#99 )
> Took 0.28 sec.
> add description
> Error Message
> /data/jenkins/workspace/impala-cdpd-master-staging-exhaustive-release/repos/Impala/tests/shell/test_shell_commandline.py:471:
> in test_utf8_decoding_error_handling assert '引�' in result.stdout E
> assert '\xe5\xbc\x95\xef\xbf\xbd' in '\xe5\xbc\x95\xe6\n' E + where
> '\xe5\xbc\x95\xe6\n' = <tests.shell.util.ImpalaShellResult object at
> 0xd848bd0>.stdout
> Stacktrace
> /data/jenkins/workspace/impala-cdpd-master-staging-exhaustive-release/repos/Impala/tests/shell/test_shell_commandline.py:471:
> in test_utf8_decoding_error_handling
> assert '引�' in result.stdout
> E assert '\xe5\xbc\x95\xef\xbf\xbd' in '\xe5\xbc\x95\xe6\n'
> E + where '\xe5\xbc\x95\xe6\n' = <tests.shell.util.ImpalaShellResult
> object at 0xd848bd0>.stdout
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
