[
https://issues.apache.org/jira/browse/IMPALA-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238512#comment-17238512
]
ASF subversion and git services commented on IMPALA-10216:
----------------------------------------------------------
Commit f07514add9956e676d99ae9cbca5855960a279f2 in impala's branch
refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f07514a ]
IMPALA-10216: make TestWriteErrorBlacklist deterministic
There is a subtle bug in the test where it does a BufferPool::Pin()
call followed immediately by a BufferPool::Unpin() call. This is
meant to ensure that a new scratch range is allocated for the file,
but does not guarantee that because the Pin() is asynchronous and
there is a short-circuit case in buffer pool that cancels the
Pin() if it the page is unpinned before the pin completes.
We can force the pin to complete by requesting the actual buffer
for the page (and verifying the data for good measure).
Testing:
I was never able to reproduce this race locally, but the fix
is pretty safe and I looped the modified test for a while.
Change-Id: I158dbc1ac60c8fefd53a138aa3e41cced9c4d674
Reviewed-on: http://gerrit.cloudera.org:8080/16782
Reviewed-by: Csaba Ringhofer <csringho...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> BufferPoolTest.WriteErrorBlacklistCompression is flaky on UBSAN builds
> ----------------------------------------------------------------------
>
> Key: IMPALA-10216
> URL: https://issues.apache.org/jira/browse/IMPALA-10216
> Project: IMPALA
> Issue Type: Bug
> Reporter: Sahil Takiar
> Assignee: Tim Armstrong
> Priority: Critical
> Labels: flaky
> Attachments: LastTest.log, LastTestsFailed.log,
> buffer-pool-test.ERROR, buffer-pool-test.INFO, buffer-pool-test.WARNING,
> buffer-pool-test.xml, impala-cdpd-master-staging-core-tsan_111.tar.gz
>
>
> Only seen this once so far:
> {code}
> BufferPoolTest.WriteErrorBlacklistCompression
> Error Message
> Value of: FindPageInDir(pages[NO_ERROR_QUERY], error_dir) != NULL
> Actual: false
> Expected: true
> Stacktrace
> Impala/be/src/runtime/bufferpool/buffer-pool-test.cc:1764
> Value of: FindPageInDir(pages[NO_ERROR_QUERY], error_dir) != NULL
> Actual: false
> Expected: true
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
