[
https://issues.apache.org/jira/browse/IMPALA-8952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Armstrong updated IMPALA-8952:
----------------------------------
Component/s: Infrastructure
> test_failpoints does not check that queries actually fail
> ---------------------------------------------------------
>
> Key: IMPALA-8952
> URL: https://issues.apache.org/jira/browse/IMPALA-8952
> Project: IMPALA
> Issue Type: Test
> Components: Infrastructure
> Reporter: Sahil Takiar
> Priority: Major
>
> While adding some additional failpoint tests in IMPALA-8934, [~kwho] pointed
> out there is a bug in the pattern below (copied from
> {{test_failpoints.py::TestFailpoints::__execute_fail_action}}):
> {code}
> try:
> result = self.execute_query(query, vector.get_value('exec_option'),
> table_format=vector.get_value('table_format'))
> assert 'Expected Failure'
> except ImpalaBeeswaxException as e:
> LOG.debug(e)
> {code}
> The assert always returns true, so the test does not truly validate that the
> queries are actually failing. After fixing this bug, about a third of the
> tests fail.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
