[
https://issues.apache.org/jira/browse/IMPALA-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257942#comment-17257942
]
ASF subversion and git services commented on IMPALA-2536:
---------------------------------------------------------
Commit a5f6c26044420498ea2e23f143dbef27243f2364 in impala's branch
refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a5f6c26 ]
IMPALA-2536: Make ColumnType constructor explicit
This avoids accidental implicit type conversions from
the PrimitiveType enum, or worse, integer values via
the enum.
Testing:
Ran core tests.
Change-Id: I2fe1d5da051c10904605328607bea78565356ef3
Reviewed-on: http://gerrit.cloudera.org:8080/16906
Reviewed-by: Wenzhe Zhou <[email protected]>
Reviewed-by: Quanlong Huang <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Make ColumnType constructor explicit to prevent certain bugs
> ------------------------------------------------------------
>
> Key: IMPALA-2536
> URL: https://issues.apache.org/jira/browse/IMPALA-2536
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 2.3.0
> Reporter: Skye Wanderman-Milne
> Assignee: Tim Armstrong
> Priority: Minor
> Labels: newbie
> Fix For: Impala 4.0
>
>
> We currently rely on the ColumnType(PrimitiveType) constructor not being
> marked explicit (e.g. we use type == TYPE_FOO in many places), but it allows
> for bugs if we accidentally pass in e.g. ints instead of types. We should be
> using type.type == TYPE_FOO anyway.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
