[ 
https://issues.apache.org/jira/browse/IMPALA-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272491#comment-17272491
 ] 

ASF subversion and git services commented on IMPALA-10452:
----------------------------------------------------------

Commit 08367e91f04508b54f77b56e0d211dd167b0116f in impala's branch 
refs/heads/master from Zoltan Borok-Nagy
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=08367e9 ]

IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax

For convenience this patch adds support with the old-style
CREATE TABLE ... PARTITIONED BY ...; syntax for Iceberg tables.

So users should be able to write the following:

CREATE TABLE ice_t (i int)
PARTITIONED BY (p int)
STORED AS ICEBERG;

Which should be equivalent to this:

CREATE TABLE ice_t (i int, p int)
PARTITION BY SPEC (p IDENTITY)
STORED AS ICEBERG;

Please note that the old-style CREATE TABLE statement creates
IDENTITY-partitioned tables. For other partition transforms the
users must use the new, more generic syntax.

Hive also supports the old PARTITIONED BY syntax with the same
behavior.

Testing:
 * added e2e tests

Change-Id: I789876c161bc0987820955aa9ae01414e0dcb45d
Reviewed-on: http://gerrit.cloudera.org:8080/16979
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>


> CREATE Iceberg tables with old PARTITIONED BY syntax
> ----------------------------------------------------
>
>                 Key: IMPALA-10452
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10452
>             Project: IMPALA
>          Issue Type: Test
>          Components: Frontend
>            Reporter: Zoltán Borók-Nagy
>            Assignee: Zoltán Borók-Nagy
>            Priority: Major
>              Labels: impala-iceberg
>
> It's convenient for users to create Iceberg tables with the old syntax.
> It's also easier to migrate existing workloads to Iceberg because the SQL 
> scripts that create the table definitions don't need to change that much.
> So users should be able to write the following:
> {noformat}
> CREATE TABLE ice_t (i int)
> PARTITIONED BY (p int)
> STORED AS ICEBERG;
> {noformat}
> Which should be equivalent to this:
> {noformat}
> CREATE TABLE ice_t (i int, p int)
> PARTITION BY SPEC (p IDENTITY)
> STORED AS ICEBERG;
> {noformat}
> Please note that the old-style CREATE TABLE creates IDENTITY-partitioned 
> tables. For other partition transforms the users must use the new, more 
> generic syntax.
> Hive also supports the PARTITIONED BY syntax, see 
> [https://github.com/apache/iceberg/pull/1612]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to