[
https://issues.apache.org/jira/browse/IMPALA-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283461#comment-17283461
]
ASF subversion and git services commented on IMPALA-9382:
---------------------------------------------------------
Commit 6fe3466d4d0a88941206aed8d265d9663758fec2 in impala's branch
refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=6fe3466 ]
IMPALA-9382: part 3/3 clean up runtime profile v2 text output
Eliminated some of the noisy per-instance counters
from DEFAULT verbosity.
Testing:
* Updated impala-profile-tool test with new output
* Added new impala-profile-tool test for v2 profile.
Change-Id: I277a0da749bcda4ecca574257b5aaacbcf222491
Reviewed-on: http://gerrit.cloudera.org:8080/17050
Reviewed-by: Tim Armstrong <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Prototype denser runtime profile implementation
> -----------------------------------------------
>
> Key: IMPALA-9382
> URL: https://issues.apache.org/jira/browse/IMPALA-9382
> Project: IMPALA
> Issue Type: Sub-task
> Components: Backend
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Major
> Attachments: profile_504b379400cba9f2_2d2cf00700000000,
> tpcds_q10_profile_v1.txt, tpcds_q10_profile_v2.txt, tpcds_q10_profile_v2.txt
>
>
> RuntimeProfile trees can potentially stress the memory allocator and use up a
> lot more memory and cache than is really necessary:
> * std::map is used throughout, and allocates a node per map entry. We do
> depend on the counters being displayed in-order, but we would probably be
> better of storing the counters in a vector and lazily sorting when needed
> (since the set of counters is generally static after Prepare()).
> * We store the same counter names redundantly all over the place. We'd
> probably be best off using a pool of constant counter names (we could just
> require registering them upfront).
> There may be a small gain from switching thrift to using unordered_map, e.g.
> for the info strings that appear with some frequency in profiles.
> However, I think we need to restructure the thrift representation and
> in-memory representation to get significant gains.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
