[ 
https://issues.apache.org/jira/browse/IMPALA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Quanlong Huang updated IMPALA-10582:
------------------------------------
    Description: 
IMPALA-6663 adds a web page for catalogd to show all in-progress operations. 
While doing a stree test for IMPALA-10563, I found that the summary tab doesn't 
sum up the operations as I expected.

!catalogd_operations.png|width=869,height=627!

As shown by the snapshot, I have 5 in-progress FINALIZE_INSERT_INTO operations. 
But in the "In-progress Catalog Operations Summary" tab, it shows 1. It makes 
sense to me to show 5 as well.

I think the reason is in be/src/catalog/catalog-server.cc, we only sum up 
requests by tables:
{code:c++}
void CatalogServer::OperationUsageUrlCallback(
    const Webserver::WebRequest& req, Document* document) {
  ...
  // Create a summary and add it to the document
  map<string, int> aggregated_operations;
  for (const auto& catalog_op : opeartion_usage.catalog_op_counters) {
    ++aggregated_operations[catalog_op.catalog_op_name];  // <---- should add 
catalog_op.op_counter here
  }
  ...
}
{code}
 cc [~tmate]

  was:
IMPALA-6663 adds a web page for catalogd to show all in-progress operations. 
While doing a stree test for IMPALA-10563, I found that the summary tab doesn't 
sum up the operations as I expected.

As shown by the snapshot, I have 5 in-progress FINALIZE_INSERT_INTO operations. 
But in the "In-progress Catalog Operations Summary" tab, it shows 1. It makes 
sense to me to show 5 as well.

I think the reason is in be/src/catalog/catalog-server.cc, we only sum up 
requests by tables:
{code:c++}
void CatalogServer::OperationUsageUrlCallback(
    const Webserver::WebRequest& req, Document* document) {
  ...
  // Create a summary and add it to the document
  map<string, int> aggregated_operations;
  for (const auto& catalog_op : opeartion_usage.catalog_op_counters) {
    ++aggregated_operations[catalog_op.catalog_op_name];  // <---- should add 
catalog_op.op_counter here
  }
  ...
}
{code}
 cc [~tmate]


> Webpage of Catalogd operations doesn't sum up operations correctly
> ------------------------------------------------------------------
>
>                 Key: IMPALA-10582
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10582
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 4.0
>            Reporter: Quanlong Huang
>            Assignee: Quanlong Huang
>            Priority: Minor
>         Attachments: catalogd_operations.png
>
>
> IMPALA-6663 adds a web page for catalogd to show all in-progress operations. 
> While doing a stree test for IMPALA-10563, I found that the summary tab 
> doesn't sum up the operations as I expected.
> !catalogd_operations.png|width=869,height=627!
> As shown by the snapshot, I have 5 in-progress FINALIZE_INSERT_INTO 
> operations. But in the "In-progress Catalog Operations Summary" tab, it shows 
> 1. It makes sense to me to show 5 as well.
> I think the reason is in be/src/catalog/catalog-server.cc, we only sum up 
> requests by tables:
> {code:c++}
> void CatalogServer::OperationUsageUrlCallback(
>     const Webserver::WebRequest& req, Document* document) {
>   ...
>   // Create a summary and add it to the document
>   map<string, int> aggregated_operations;
>   for (const auto& catalog_op : opeartion_usage.catalog_op_counters) {
>     ++aggregated_operations[catalog_op.catalog_op_name];  // <---- should add 
> catalog_op.op_counter here
>   }
>   ...
> }
> {code}
>  cc [~tmate]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to