[ 
https://issues.apache.org/jira/browse/IMPALA-10596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313032#comment-17313032
 ] 

ASF subversion and git services commented on IMPALA-10596:
----------------------------------------------------------

Commit 96e7f85275056dd4ec1460ec8df3afb86d401e43 in impala's branch 
refs/heads/master from Bikramjeet Vig
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=96e7f85 ]

IMPALA-10596: De-flake teardown in TestAdmissionControllerStress

Currently if the threads running queries in
TestAdmissionControllerStress hit an error, they close their client
which ultimately closes the query that it was running. If teardown()
runs after the client is closed, it tries to cancel the query that
the thread was running and hits an exception trying to cancel an
already closed query. This results in the pytest throws the exception
encountered in teardown() instead of the original exception that
caused the test to fail in the first place. This patch fixes this by
removing the query handle from the thread if the client is closed.

Testing:
Simulated hitting an error condition in the main thread that
initially triggered this condition.

Change-Id: I8aa8315d9f598ba80d13cd2091e3cc743c64ba77
Reviewed-on: http://gerrit.cloudera.org:8080/17256
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> TestAdmissionControllerStressWithACService.test_mem_limit fails with "Invalid 
> or unknown query handle" when canceling a query
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: IMPALA-10596
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10596
>             Project: IMPALA
>          Issue Type: Bug
>    Affects Versions: Impala 4.0
>            Reporter: Andrew Sherman
>            Assignee: Bikramjeet Vig
>            Priority: Critical
>
> TestAdmissionControllerStress.test_mem_limit fails similarly
> {code}
> custom_cluster/test_admission_controller.py:1437: in teardown
>     client.cancel(thread.query_handle)
> common/impala_connection.py:215: in cancel
>     return self.__beeswax_client.cancel_query(operation_handle.get_handle())
> beeswax/impala_beeswax.py:369: in cancel_query
>     return self.__do_rpc(lambda: self.imp_service.Cancel(query_id))
> beeswax/impala_beeswax.py:520: in __do_rpc
>     raise ImpalaBeeswaxException(self.__build_error_message(b), b)
> E   ImpalaBeeswaxException: ImpalaBeeswaxException:
> E    INNER EXCEPTION: <class 'beeswaxd.ttypes.BeeswaxException'>
> E    MESSAGE: Invalid or unknown query handle: 
> 174962332188aac2:1713d0fe00000000.
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to