[
https://issues.apache.org/jira/browse/IMPALA-10591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313295#comment-17313295
]
ASF subversion and git services commented on IMPALA-10591:
----------------------------------------------------------
Commit 8ac761348aa805b53e0a13d85fd5c9b2de5f3985 in impala's branch
refs/heads/master from Thomas Tauber-Marshall
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=8ac7613 ]
IMPALA-10591: Handle failed ReleaseQueryBackends rpcs
When the admission control service is in use, coordinators will
retry failed ReleaseQueryBackends rpcs 3 times before giving up.
This can potentially result in resources not being released when they
are no longer in use.
This patch fixes the issue by automatically releasing all remaining
backends when ReleaseQuery is called in the context of the admission
control service (either as the result of a ReleaseQUery rpc or when
cleaning up a query's resources with the heartbeat mechanism).
Testing:
- Added a custom cluster test that simulates failed
ReleaseQueryBackends rpcs and ensures that query resources are
eventually released.
Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9
Reviewed-on: http://gerrit.cloudera.org:8080/17208
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Thomas Tauber-Marshall <[email protected]>
> Fix issues with failed ReleaseQueryBackends rpc
> -----------------------------------------------
>
> Key: IMPALA-10591
> URL: https://issues.apache.org/jira/browse/IMPALA-10591
> Project: IMPALA
> Issue Type: Sub-task
> Components: Backend
> Affects Versions: Impala 4.0
> Reporter: Thomas Tauber-Marshall
> Priority: Major
>
> Currently, if the admission control service is being used, the coordinator
> will attempt the ReleaseQueryBackends rpc up to 3 times before giving up. If
> a ReleaseQueryBackends rpc fails it can lead to resources not being released
> properly. If a subsequent ReleaseQuery rpc succeeds, we'll hit a DCHECK as
> AdmissionController::ReleaseQuery() assumes that all backends have already
> been released.
> We should clean this up and ensure that resources are always released
> properly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
