[ 
https://issues.apache.org/jira/browse/IMPALA-10649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317358#comment-17317358
 ] 

Laszlo Gaal commented on IMPALA-10649:
--------------------------------------

cc: [~joemcdonnell]

> Check only OS major version during toolchain bootstrap
> ------------------------------------------------------
>
>                 Key: IMPALA-10649
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10649
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 4.0
>            Reporter: Laszlo Gaal
>            Assignee: Laszlo Gaal
>            Priority: Major
>
> Reviewing {{bin/bootstrap_toolchain.py}} while fixing IMPALA-10646 revealed 
> that it checks the OS minor version only when running on Ubuntu. On all other 
> supported platforms (Suse, Centos, Red Hat) the code is happy with just the 
> major version.
> https://github.com/apache/impala/blob/master/bin/bootstrap_toolchain.py#L92-L98
>  reveals that minor versions are irrelevant for Ubuntu: the code happily maps 
> toolchain versions even across _major_ versions of Ubuntu.
> My proposal is to remove the minor version check from 
> {{bootstrap_toolchain.py}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to