[ 
https://issues.apache.org/jira/browse/IMPALA-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317479#comment-17317479
 ] 

ASF subversion and git services commented on IMPALA-10637:
----------------------------------------------------------

Commit 5d307cbb7b2ec3432bebd7759b0bcebf54a6cc22 in impala's branch 
refs/heads/master from Sourabh Goyal
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=5d307cb ]

IMPALA-10637: Fixes bug in ValidWriteIdList comparison

For a transactional table, catalogd compares previous and current ValidWriteList
to determine more recent version out of the two and reloads table cache 
accordingly.
Because of a bug in ValidWriteIdList comparison, catalogD was not refreshing 
table 
metadata in the cache with more recent changes. As a result of which we were 
seeing 
inconsistencies in read after write into the table.

Tested by
  1. Adding a unit test to compare WriteIDLists.

Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc
Reviewed-on: http://gerrit.cloudera.org:8080/17276
Reviewed-by: Sourabh Goyal <[email protected]>
Reviewed-by: Vihang Karajgaonkar <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Bug in ValidWriteIdList comparison in AcidUtils
> -----------------------------------------------
>
>                 Key: IMPALA-10637
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10637
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Catalog
>            Reporter: Sourabh Goyal
>            Priority: Major
>
> There is a bug in 
> [this|https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/util/AcidUtils.java#L752]
>  line of code in AcidUtils.java. 
> Example scenario: 
> For validWriteIdLists: 
> ValidWriteIdList a = new ValidReaderWriteIdList("default.test:1:1:1:");
> ValidWriteIdList b = new 
> ValidReaderWriteIdList("default.test:1:9223372036854775807::");
> AcidUtils.compare(a, b) currently returns +1 whereas the expected answer is 
> -1 since b is more recent.
> cc - [~kishendas] [~vihangk1]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to