[
https://issues.apache.org/jira/browse/IMPALA-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324483#comment-17324483
]
ASF subversion and git services commented on IMPALA-10657:
----------------------------------------------------------
Commit a1a1f9922565f866692b17c82106a1a8f6ac64a5 in impala's branch
refs/heads/master from John Sherman
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a1a1f99 ]
IMPALA-10657: Remove accidental usage of shaded imports
- This changes seemingly accidental usages of shaded imports
with the direct dependency
- This is helpful to reduce confusion and possibly reduce the
required jars for certain usages of the frontend jars
Change-Id: Ifa67aec96539db7861416f3e71cca83607e3d8c9
Reviewed-on: http://gerrit.cloudera.org:8080/17314
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Remove usage of shaded imports
> ------------------------------
>
> Key: IMPALA-10657
> URL: https://issues.apache.org/jira/browse/IMPALA-10657
> Project: IMPALA
> Issue Type: Improvement
> Components: Frontend
> Reporter: John Sherman
> Assignee: John Sherman
> Priority: Major
>
> It seems there are a few spots where maybe an IDE automatically resolved a FE
> or test import to from a shaded dependency. We should use the direct
> dependency to remove confusion and reduce the required jars for some usages
> of the FE code.
> Examples being:
> fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java uses
> org.apache.kudu.shaded.com.google.common.collect.Lists
> fe/src/main/java/org/apache/impala/catalog/Transaction.java uses
> org.apache.curator.shaded.com.google.common.base.Preconditions
> fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java use
> org.apache.curator.shaded.com.google.common.collect.Iterables
> fe/src/test/java/org/apache/impala/analysis/ExprCardinalityTest.java uses
> org.apache.curator.shaded.com.google.common.collect.Sets
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
