[
https://issues.apache.org/jira/browse/IMPALA-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337700#comment-17337700
]
ASF subversion and git services commented on IMPALA-10471:
----------------------------------------------------------
Commit 87384e3377ee25f56a16573cf8493c19b4578258 in impala's branch
refs/heads/master from Amogh Margoor
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=87384e3 ]
IMPALA-10471: Making deadline for Shutdown by SIGRTMIN configurable
Making deadline for Shutdown caused by SIGRTMIN configurable
using flag: shutdown_deadline_s. The deadline for shutdown
by SIGRTMIN was fixed to 1 year and was independent of the
flag earlier. This patch ensures even this shutdown behaviour
is governed by the common flag: shutdown_deadline_s.
TESTING:
1. Modified existing test to reflect the configurable deadline.
2. Verified manually
3. Ran the cluster tests (which include test_restart_services)
Change-Id: I52cb1ba76e7ce9de86ceb2f84389b1ab257e4c05
Reviewed-on: http://gerrit.cloudera.org:8080/17348
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Make deadline configurable for SIGTERMIN graceful shutdown
> -----------------------------------------------------------
>
> Key: IMPALA-10471
> URL: https://issues.apache.org/jira/browse/IMPALA-10471
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 4.0
> Reporter: Tamas Mate
> Assignee: Amogh Margoor
> Priority: Minor
> Labels: ramp-up
>
> While the graceful shutdown deadline can be configured when the SHUTDOWN()
> statement is executed, when the shutdown is initiated with SIGTERMIN signal
> it will use a default 1 year deadline. The related
> {{ImpalaShutdownSignalHandler}} can be found
> [here|https://github.com/apache/impala/blame/a81c6a78294d1da72b57ed90ec4e365de8c4e54b/be/src/common/init.cc#L179].
> {code:java}
> ...
> const int ONE_YEAR_IN_SECONDS = 365 * 24 * 60 * 60;
> Status status = impala_server->StartShutdown(ONE_YEAR_IN_SECONDS,
> &shutdown_status);
> ...
> {code}
> The {{--shutdown_deadline_s}} flag should be respected in this case as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
