Zoltán Borók-Nagy created IMPALA-10698:
------------------------------------------
Summary: Remove branching based on MetastoreShim.getMajorVersion()
Key: IMPALA-10698
URL: https://issues.apache.org/jira/browse/IMPALA-10698
Project: IMPALA
Issue Type: Improvement
Components: Frontend
Reporter: Zoltán Borók-Nagy
IMPALA-9731 dropped support for Hive 2 and removed most code associated with it.
However we still have if statements that check MetastoreShim.getMajorVersion().
One can check it with:
{noformat}
git grep getMajorVersion
{noformat}
It would be nice to get rid of these because the
MetastoreShim.getMajorVersion() == 2 branches are dead code now.
Moreover, in the test code there are still some places that check for
HIVE_MAJOR_VERSION == 2, e.g.:
https://github.com/apache/impala/blob/c10e7c969dfcc4847a8f7708940f4aa1852dbee4/tests/metadata/test_hms_integration.py#L215
These can be also removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
