[
https://issues.apache.org/jira/browse/IMPALA-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386960#comment-17386960
]
ASF subversion and git services commented on IMPALA-10814:
----------------------------------------------------------
Commit b3c4ac9054aabcfbf04304b315d1b3103c952228 in impala's branch
refs/heads/master from Zoltan Borok-Nagy
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b3c4ac9 ]
IMPALA-10814: Fix crash on illegal Parquet file
In IMPALA-7087/IMPALA-8131 we allowed reading decimals with
different precision/scale than table metadata. To allow this
we relaxed some checks against the Parquet file schema.
However we should still add some sanity checks, e.g. ignoring
negative values, require that scale is not greater than precision.
This patch adds these sanity checks. Without these checks we might
hit DCHECKS in Parquet fuzz testing.
Change-Id: Ic6b06ac00e2af8f405f7b2b3c2eb952683821431
Reviewed-on: http://gerrit.cloudera.org:8080/17714
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Hit DCHECK in DecimalUtil::DecodeFromFixedLenByteArray for core-s3 build
> ------------------------------------------------------------------------
>
> Key: IMPALA-10814
> URL: https://issues.apache.org/jira/browse/IMPALA-10814
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 4.1
> Reporter: Wenzhe Zhou
> Assignee: Zoltán Borók-Nagy
> Priority: Major
> Labels: broken-build
>
> Saw this build failure in asf-master-core-s3 build:
> [https://master-03.jenkins.cloudera.com/job/impala-asf-master-core-s3/61/]
>
> *Error Message*
> DCHECK found in log file:
> /data/jenkins/workspace/impala-asf-master-core-s3/repos/Impala/logs/ee_tests/impalad.FATAL
> h3. Standard Error
> Log file created at: 2021/07/19 18:41:06 Running on machine:
> [impala-ec2-centos74-m5-4xlarge-ondemand-072f.vpc.cloudera.com|http://impala-ec2-centos74-m5-4xlarge-ondemand-072f.vpc.cloudera.com/]
> Log line format: [IWEF]mmdd hh:mm:ss.uuuuuu threadid
> [file:line|file:///line]] msg
> F0719 18:41:06.730994 4601 decimal-util.h:129]
> fb4b98709a88f345:b51bf00b00000002] Check failed: fixed_len_size > 0 (-15 vs.
> 0)
> F0719 18:41:08.161149 4711 decimal-util.h:129]
> e5432b6d3730539d:cf6c2d3100000002] Check failed: fixed_len_size > 0 (-15 vs.
> 0)
>
> From timestamp, the issue seems happened in test:
> query_test/test_scanners_fuzz.py::TestScannersFuzzing::test_fuzz_uncompressed_parquet_orc
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
