[
https://issues.apache.org/jira/browse/IMPALA-10975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432632#comment-17432632
]
ASF subversion and git services commented on IMPALA-10975:
----------------------------------------------------------
Commit be80b1c442b56ff12c504c210a7a97076cb3672c in impala's branch
refs/heads/master from Sourabh Goyal
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=be80b1c ]
IMPALA-10975: Refactor alter table ddl operation
For almost all alter table DDL operations in catalogOpExecutor,
a table is added to catalog update at a common place in the end
if reloadMetadata is true. However for few sub ddl operations like ADD
and DROP partitions, addTableToCatalogUpdate() is called locally.
This patch is to refactor addTableToCatalogUpdate() and call it at one
place for all the sub ddls.
After this patch, a table (after alter table ddl) is added to catalog
update if its old catalog version does not match the current catalog
version.
This patch also addresses a bug in which a HMS event was getting
added to delete event log even if event processing is not active.
Testing:
Relying on existing tests since it is a minor refactoring.
Change-Id: Ifbadcab68b4599ad18b681b1284052a47b74d802
Reviewed-on: http://gerrit.cloudera.org:8080/17919
Reviewed-by: Vihang Karajgaonkar <[email protected]>
Tested-by: Vihang Karajgaonkar <[email protected]>
> Minor refactoring in alter table DDL operation in catalogd
> ----------------------------------------------------------
>
> Key: IMPALA-10975
> URL: https://issues.apache.org/jira/browse/IMPALA-10975
> Project: IMPALA
> Issue Type: Improvement
> Components: Catalog, Frontend
> Reporter: Sourabh Goyal
> Assignee: Sourabh Goyal
> Priority: Major
>
> For almost all alter table DDL operations in catalogOpExecutor, we add table
> to catalog update if reloadMetadata is true in the end. However for certain
> sub ddl operations like ADD and DROP partitions, the table to update catalog
> is performed locally. This Jira is to refactor addTableToCatalogUpdate() and
> call it from one place for all the sub ddls. This refactoring would be
> helpful when we introduce code changes of syncing db/table to latest event id
> from catalogOpExecutor in future.
>
> cc - [~vihangk1]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
