[ 
https://issues.apache.org/jira/browse/IMPALA-10951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470285#comment-17470285
 ] 

ASF subversion and git services commented on IMPALA-10951:
----------------------------------------------------------

Commit 7b490eed5b4e18be1ab19e190ec9ad14c2a804d1 in impala's branch 
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=7b490ee ]

IMPALA-10951 (preparation): Update Kudu to a more recent version

As part of moving to a newer protobuf, this updates the Kudu version
to get the fix for KUDU-3334. With this newer Kudu version, Clang
builds hit an error while linking:
lib/libLLVMCodeGen.a(TargetPassConfig.cpp.o):TargetPassConfig.cpp:
  function llvm::TargetPassConfig::createRegAllocPass(bool):
    error: relocation refers to global symbol "std::call_once<void 
(&)()>(std::once_flag&, void (&)())::{lambda()#2}::_FUN()",
    which is defined in a discarded section
  section group signature: 
"_ZZSt9call_onceIRFvvEJEEvRSt9once_flagOT_DpOT0_ENKUlvE0_clEv"
  prevailing definition is from 
../../build/debug/security/libsecurity.a(openssl_util.cc.o)
(This is from a newer binutils that will be pursued separately.)

As a hack to get around this error, this adds the calloncehack
shared library. The shared library publicly defines the symbol that
was coming from kudu_client. By linking it ahead of kudu_client, the
linker uses that rather than the one from kudu_client. This fixes
the Clang builds.

The new Kudu also requires a minor change to the flags for tserver
startup.

Testing:
 - Ran debug tests and verified calloncehack is not used
 - Ran ASAN tests

Change-Id: Ieccbe284f11445e1de792352ebc7c9e1fa2ca0c3
Reviewed-on: http://gerrit.cloudera.org:8080/18129
Reviewed-by: Wenzhe Zhou <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Upgrade protobuf library for Impala
> -----------------------------------
>
>                 Key: IMPALA-10951
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10951
>             Project: IMPALA
>          Issue Type: Sub-task
>          Components: Backend
>    Affects Versions: Impala 4.1.0
>            Reporter: Wenzhe Zhou
>            Assignee: Wenzhe Zhou
>            Priority: Major
>             Fix For: Impala 4.1.0
>
>
> Some of third party libraries in Impala native tool-chains are be older than 
> the ones in Kudu repo.  We need to upgrade these libraries since Kudu code 
> use some new APIs in these libraries. We should upgrade these libraries as 
> their own separate change. These bigger changes tend to have preparation 
> patches to line things up, then the switchover.
> We need to upgrade protobuf library from 3.5.1 to 3.14.0. This requires code 
> change in native-toolchain and impala.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to