[ 
https://issues.apache.org/jira/browse/IMPALA-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493370#comment-17493370
 ] 

ASF subversion and git services commented on IMPALA-10779:
----------------------------------------------------------

Commit 92ce6fe48e75d7780efe9a275122554e59aac916 in impala's branch 
refs/heads/master from wzhou-code
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=92ce6fe ]

IMPALA-10931 (part2): Fixed rebased Kudu source to compile

This patch applies various fixes to Impala and to the copied Kudu
source code in be/src/kudu/* to allow everything to compile and pass
Impala exhaustive tests.

Highlights of the changes made:
- Some flags that have a DEFINE in both Kudu and Impala are modified
  to change one of the DEFINEs to a DECLARE.
- Fixed backend unit-test bloom-filter-test.cc due to the changes for
  block bloom filter false positive rate correction in
  kudu/util/block_bloom_filter.cc.
- Set initial values of Sockaddr variables as Sockaddr::Wildcard().
- The parameter type of kudu::RpcSidecar::FromFaststring() was changed,
  need to change the caller code in Impala.
- openssl_util.h was moved from directory kudu/security to kudu/util.
  need to change including path in Impala.

This patch was in part based on the patches that were applied the last
time we rebased the Kudu code in IMPALA-9335. All changes from those
commits that are still relevant were included here.

Went through all commits that have been applied to the be/src/kudu
directory since the last rebase and ensured that all relevant changes
from those are included here. These include patches for IMPALA-9182,
IMPALA-10779, IMPALA-9940 and commit d9a38c0bac (Limit short versions
of KUDU_* macros to Kudu source).

Testing:
- Passed core debug build, core ASAN build and exhaustive release
  build.

Change-Id: Ia9919c06e60d132d997093abb7b14825847e07c7
Reviewed-on: http://gerrit.cloudera.org:8080/18155
Reviewed-by: Joe McDonnell <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Print the username closing a session or cancelling a query from the WebUI
> -------------------------------------------------------------------------
>
>                 Key: IMPALA-10779
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10779
>             Project: IMPALA
>          Issue Type: Improvement
>            Reporter: Quanlong Huang
>            Assignee: Fucun Chu
>            Priority: Major
>             Fix For: Impala 4.1.0
>
>
> IMPALA-9182 prints the socket address of the client closing a session or 
> cancelling a query from the WebUI. There is a 'remote_user' field in 
> {{sq_request_info}}. We may be able to print the username when auth is 
> enabled.
> {code:cpp}
> // This structure contains information about the HTTP request.
> struct sq_request_info {
>   const char *request_method; // "GET", "POST", etc
>   const char *uri;            // URL-decoded URI
>   const char *http_version;   // E.g. "1.0", "1.1"
>   const char *query_string;   // URL part after '?', not including '?', or 
> NULL
>   const char *remote_user;    // Authenticated user, or NULL if no auth used
>   long remote_ip;             // Client's IP address
>   int remote_port;            // Client's port
>   int is_ssl;                 // 1 if SSL-ed, 0 if not
>   void *user_data;            // User data pointer passed to sq_start()
>   void *conn_data;            // Connection-specific user data
>   int num_headers;            // Number of HTTP headers
>   struct sq_header {
>     const char *name;         // HTTP header name
>     const char *value;        // HTTP header value
>   } http_headers[64];         // Maximum 64 headers
> };
> {code}
> https://github.com/apache/impala/blob/59d32853ee42886ae683aac95a8be7f9c89b8eb7/be/src/thirdparty/squeasel/squeasel.h#L77



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to