[
https://issues.apache.org/jira/browse/IMPALA-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570342#comment-17570342
]
Laszlo Gaal commented on IMPALA-11439:
--------------------------------------
Thank you for the improvement, this is a valid concern indeed. However, I'd
like to suggest a slightly different (while mostly equivalent) implementation.
The current implementation flips the default behavior of this download step to
its complete opposite: the old behavior was always to attempt the download,
while the new behavior would never attempt the download unless the environment
variable is set to request it explicitly.
The build process already has a few such environment variables that govern
various behaviors, e.g. {{SKIP_TOOLCHAIN_BOOTSTRAP}}, {{SKIP_PYTHON_DOWNLOAD}}.
These flags follow a "suppression-type" behavior: when they are absent, the
download action happens; when they are set, the download actio is skipped.
I'd suggest changing the behavior of {{PREPOPULATE_M2_REPOSITORY}} to match
these: leave the default behavior as-is; change the name of the flag to
{{SKIP_PREPOPULATE_M2_REPOSITORY}} (or something like it), and skip the tarball
download when the SKIP_... flag is set.
This would preserve the default behavior of buildall.sh (i.e. when the
environment variable is missing), while still enabling you to suppress the
download if/when desired. This pattern would also make it unnecessary to change
existing build scripts just to keep the existing download behavior (e.g. on
jenkins.impala.io among others).
Thanks a lot for considering; please feel free to raise any comments or
concerns.
cc: [~joemcdonnell]
> Add an environment variable to control bootstrap_system.sh whether to
> prepopulate the m2 directory or not
> ----------------------------------------------------------------------------------------------------------
>
> Key: IMPALA-11439
> URL: https://issues.apache.org/jira/browse/IMPALA-11439
> Project: IMPALA
> Issue Type: Improvement
> Affects Versions: Impala 4.1.0
> Reporter: yx91490
> Assignee: yx91490
> Priority: Major
>
> Currently bootstrap_system.sh will prepopulate the .m2 directory by download
> a 800M+ archive file from jenkins.impala.io, this intended to speed up the
> maven package process, so it's not required. meanwhile, due to different
> network environment, the download speed of the archive file is not
> necessarily fast.
> I want to add an environment variable 'PREPOPULATE_M2_REPOSITORY' to control
> whether to prepopulate the m2 directory or not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
