[
https://issues.apache.org/jira/browse/IMPALA-11249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584815#comment-17584815
]
ASF subversion and git services commented on IMPALA-11249:
----------------------------------------------------------
Commit b28e133f008e5196bf2bc7f2114cc45d0dfbe963 in impala's branch
refs/heads/branch-4.1.1 from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b28e133f0 ]
IMPALA-11249: Fix add_test_dimensions() locations to call super()
The original issue is that the strict HS2 shell tests
are not running in precommit or nightly jobs, but they
do run in local developer environments. Investigating
this showed that the shell tests were running with a
weird set of test dimensions that includes
table_format_and_file_extension. That dimension is only
used in test_insert.py::TestInsertFileExtension.
What is happening is that the shell tests and other
locations are running add_test_dimensions() without
calling super(..., cls).add_test_dimensions(). The
behavior is unclear, but there is clearly cross-talk
between the different tests that do this.
This changes all add_test_dimensions() locations to
call super(..., cls).add_test_dimensions() if they
don't already. Each location has been tuned to run
the same set of tests as before (except the shell
tests which now run the strict HS2 tests).
As part of this, several shell tests need to be
skipped or fixed for strict HS2.
Testing:
- Ran core job
- Ran tests locally to verify the set of tests
didn't change.
Change-Id: Ib20fd479d3b91ed0ed89a0bc5623cd2a5a458614
Reviewed-on: http://gerrit.cloudera.org:8080/18557
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-on: http://gerrit.cloudera.org:8080/18905
Reviewed-by: Wenzhe Zhou <[email protected]>
Tested-by: Quanlong Huang <[email protected]>
> Precommits are not running strict_hs2_protocol=True configurations for shell
> tests
> ----------------------------------------------------------------------------------
>
> Key: IMPALA-11249
> URL: https://issues.apache.org/jira/browse/IMPALA-11249
> Project: IMPALA
> Issue Type: Bug
> Components: Clients
> Affects Versions: Impala 4.1.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
> Fix For: Impala 4.2.0
>
>
> When debugging a shell test failure, I noticed that the set of tests running
> in precommit is different from what happens when I run in my development
> environment. In precommit, none of the strict_hs2_protocol=True shell tests
> run. I can't figure out why it behaves that way from the code, given that we
> enable this test dimension:
> {noformat}
> def add_test_dimensions(cls):
> # Run with both beeswax and HS2 to ensure that behaviour is the same.
> cls.ImpalaTestMatrix.add_dimension(create_client_protocol_dimension())
>
> cls.ImpalaTestMatrix.add_dimension(create_client_protocol_strict_dimension())
> cls.ImpalaTestMatrix.add_constraint(lambda v:
> v.get_value('protocol') != 'beeswax' or not
> v.get_value('strict_hs2_protocol')){noformat}
> And create_client_protocol_strict_dimension() should produce both False and
> True:
> {noformat}
> def create_client_protocol_strict_dimension():
> # only support strict dimensions if the file system is HDFS, since that is
> # where the hive cluster is run.
> if IS_HDFS:
> return ImpalaTestDimension('strict_hs2_protocol', False, True)
> else:
> return create_client_protocol_no_strict_dimension(){noformat}
> When I run locally, those tests run (and there are some failures to fix).
> Example precommit job:
> https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/16296/testReport/shell.test_shell_interactive/TestImpalaShellInteractive/
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
