[
https://issues.apache.org/jira/browse/IMPALA-11569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602540#comment-17602540
]
ASF subversion and git services commented on IMPALA-11569:
----------------------------------------------------------
Commit 53da1e737bf2c9684913765a859abe34d4c1a8bc in impala's branch
refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=53da1e737 ]
IMPALA-11569: Run finalize.sh in all-tests.sh even if dataload fails
bin/jenkins/all-tests.sh does not run finalize.sh if
bin/bootstrap_development.sh fails. This is inconvenient,
because sometimes Impala can crash during dataload, and
it is useful for finalize.sh to resolve any minidumps.
This changes all-tests.sh to run finalize.sh even if
bootstrap_development.sh fails.
Testing:
- Ran this on an ARM job that was failing during
dataload. Finalize ran properly.
Change-Id: I46fcc1d552341607ada9a6c37f6a5fb13be213a5
Reviewed-on: http://gerrit.cloudera.org:8080/18955
Reviewed-by: Michael Smith <[email protected]>
Reviewed-by: Wenzhe Zhou <[email protected]>
Tested-by: Joe McDonnell <[email protected]>
> Run finalize.sh in bin/jenkins/all-tests.sh even if dataload fails
> ------------------------------------------------------------------
>
> Key: IMPALA-11569
> URL: https://issues.apache.org/jira/browse/IMPALA-11569
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 4.2.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
>
> bin/jenkins/all-tests.sh (used for precommit Jenkins jobs) has "set -oeu
> pipefail" set, so if a command fails, it will exit. Currently, it sources
> bin/bootstrap_development.sh, so if that fails it will not run finalize.sh.
> {noformat}
> source bin/bootstrap_development.sh
> ...
> RET_CODE=0
> if ! bin/run-all-tests.sh; then
> RET_CODE=1
> fi
> # Shutdown minicluster at the end
> testdata/bin/kill-all.sh
> bin/jenkins/finalize.sh
> exit $RET_CODE{noformat}
> finalize.sh is useful for resolving minidumps and generating JUnitXML.
> bootstrap_development.sh runs dataload, so Impala could crash and finalize.sh
> wouldn't run. We should change it so that finalize.sh runs even if dataload
> fails.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
