[
https://issues.apache.org/jira/browse/IMPALA-11515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602543#comment-17602543
]
Joe McDonnell commented on IMPALA-11515:
----------------------------------------
The fix has been merged, and an ARM job successfully built the toolchain.
{noformat}
Author: Joe McDonnell <[email protected]>
Date: Thu Sep 8 15:44:02 2022 -0700 IMPALA-11515: Do not use
--load-average if ninja is installed
Kudu will use ninja if it is installed. Since ninja
does not support --load-average, the Kudu build will
fail if it runs on a machine with ninja installed.
This detects whether ninja is installed and does
not use --load-average. This only applies to one
step of the Kudu build. The usual method of building
native-toolchain does not have ninja installed, so
this is an unusual case.
Testing:
- Tested the logic by hand inside a docker image. Tried
without ninja installed, then installed ninja and tried
again.
Change-Id: I7335186c70aa98de3c2b8d15264a29ec485ce784
Reviewed-on: http://gerrit.cloudera.org:8080/18957
Reviewed-by: Michael Smith <[email protected]>
Reviewed-by: Wenzhe Zhou <[email protected]>
Tested-by: Joe McDonnell <[email protected]>{noformat}
> Adding --load-average to native-toolchain's Kudu compilation broke ARM jobs
> ---------------------------------------------------------------------------
>
> Key: IMPALA-11515
> URL: https://issues.apache.org/jira/browse/IMPALA-11515
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: Impala 4.2.0
> Reporter: Joe McDonnell
> Priority: Major
>
> In IMPALA-11370, we changed the compilation of Kudu to specify
> EXTRA_MAKEFLAGS="--load-average=${BUILD_THREADS}". This works fine when Kudu
> is compiling using Make. However, if Ninja is installed, Kudu will use it.
> Ninja does not support --load-average, and it will exit immediately.
> This is a problem for the ARM jobs that build native-toolchain as part of
> bootstrap_system.sh. bootstrap_system.sh installs ninja, so this will always
> fail.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
