[
https://issues.apache.org/jira/browse/IMPALA-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619925#comment-17619925
]
ASF subversion and git services commented on IMPALA-11657:
----------------------------------------------------------
Commit 73e2e0a5831330d85ea6aeaa237a575254ea5e6b in impala's branch
refs/heads/master from stiga-huang
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=73e2e0a58 ]
IMPALA-11657: Ignore git-reset failures in build-all-flag-combinations.sh
When building from a tarball, the git-reset command in
build-all-flag-combinations.sh will fail since it's executed not in a
git repository. The purpose of the command is to revert the changes made
by "mvn versions:set". It's ok to skip this step when building in a
Jenkins job, since that's the last build to verify. No following builds
will be impacted.
This patch ignores the failure of git-reset. So we can set up a Jenkins
job to run build-all-flag-combinations.sh from a tarball.
Tests:
- Verified the script from a tarball locally.
Change-Id: I2079de0b1eb11044d5293546fe6641939d978134
Reviewed-on: http://gerrit.cloudera.org:8080/19135
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> build-all-flag-combinations.sh should tolerate git-reset failures
> -----------------------------------------------------------------
>
> Key: IMPALA-11657
> URL: https://issues.apache.org/jira/browse/IMPALA-11657
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Reporter: Quanlong Huang
> Assignee: Quanlong Huang
> Priority: Major
>
> When building all options from a tarball using
> bin/jenkins/build-all-flag-combinations.sh, the build will finally failed by
> this:
> {noformat}
> fatal: Not a git repository (or any of the parent directories): .git
> ERROR in ./bin/jenkins/build-all-flag-combinations.sh at line 130: git reset
> --hard HEAD
> Generated:
> /home/ubuntu/apache-impala-4.1.1/logs/extra_junit_xml_logs/generate_junitxml.buildall.build-all-flag-combinations.20221013_02_26_28.xml
> ./bin/jenkins/build-all-flag-combinations.sh: Cleaning up temporary directory
> {noformat}
> The corresponding code snipper:
> {code:bash}
> # Reset the files changed by mvn versions:set
> git reset --hard HEAD{code}
> [https://github.com/apache/impala/blob/4.1.1-rc2/bin/jenkins/build-all-flag-combinations.sh#L130]
> The failure of git-reset should be ignored. CC [~joemcdonnell]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
