[
https://issues.apache.org/jira/browse/IMPALA-11478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625050#comment-17625050
]
Peter Rozsa commented on IMPALA-11478:
--------------------------------------
getDbs, getTableNames functions are used in the catalog webserver, they should
remain.
> Cleanup JniCatalog
> ------------------
>
> Key: IMPALA-11478
> URL: https://issues.apache.org/jira/browse/IMPALA-11478
> Project: IMPALA
> Issue Type: Task
> Components: Frontend
> Reporter: Quanlong Huang
> Assignee: Peter Rozsa
> Priority: Major
> Labels: newbie, ramp-up
>
> There are some dead codes in JniCatalog. E.g. getDbs, getTableNames,
> getFunctions are not used by coordinator. Instead, coordinator uses its own
> methods in JniFrontend. So these methods can be removed.
> [https://github.com/apache/impala/blob/29a26a536c004e4d16fdb56e1bb5a41605ae4e30/fe/src/main/java/org/apache/impala/service/JniCatalog.java#L272-L311]
> [https://github.com/apache/impala/blob/29a26a536c004e4d16fdb56e1bb5a41605ae4e30/fe/src/main/java/org/apache/impala/service/JniCatalog.java#L366-L391]
> On the other side, the other RPC code paths in JniCatalog need some
> simplification (after IMPALA-11401) since they are similar. Mostly using a
> try-catch clause to wrap the internal call with thread annotation and error
> handling, and log some message about start/finish the RPC. As [~csringhofer]
> mentioned in the code review of
> [https://gerrit.cloudera.org/c/18772/5/fe/src/main/java/org/apache/impala/service/JniCatalog.java#227],
> it could also make sense to create a class hierarchy like CatalogJniOp with
> the basic common skeleton of these functions
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
