[
https://issues.apache.org/jira/browse/IMPALA-11669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625485#comment-17625485
]
ASF subversion and git services commented on IMPALA-11669:
----------------------------------------------------------
Commit ea6173440c4e3d56ce12c98aca157c4aaa865cbc in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=ea6173440 ]
IMPALA-11669: Set TConfiguration during Thrift connection setup
THRIFT-5237 Implement MAX_MESSAGE_SIZE and consolidate limits into a
TConfiguration class. The MAX_MESSAGE_SIZE default to 100MB. This patch
adds backend flag 'thrift_rpc_max_message_size' to override the default
MAX_MESSAGE_SIZE by calling function AssignDefaultTConfiguration.
We set higher default, 1GB, to minimize interruption on existing Impala
workload. We should consider lowering this default once we ensure that
all thrift rpc response can be made in batches, such as explained in
IMPALA-11402.
Thrift tuning for communication with HMS is fixed through HIVE-26633.
Appropriate Hive version bump is required.
Testing:
- Add EXPECT_NO_THROW to verify that 'checkReadBytesAvailable' to does
not throw exception given default FLAGS_thrift_rpc_max_message_size.
- Add MaxMessageSizeFit and MaxMessageSizeExceeded tests in
thrift-server-test.
- Run and pass thrift-server-test
Change-Id: I137683d43c72a34105fd7b32fea3a93532601ae3
Reviewed-on: http://gerrit.cloudera.org:8080/19162
Reviewed-by: Wenzhe Zhou <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Make Thrift max message size configuration
> ------------------------------------------
>
> Key: IMPALA-11669
> URL: https://issues.apache.org/jira/browse/IMPALA-11669
> Project: IMPALA
> Issue Type: Task
> Components: Backend
> Affects Versions: Impala 4.2.0
> Reporter: Joe McDonnell
> Assignee: Riza Suminto
> Priority: Critical
>
> With the upgrade to Thrift 0.16, Thrift now has a protection against
> malicious message in the form of a maximum size for messages. This is
> currently set to 100MB by default. Impala should add the ability to override
> this default value. In particular, it seems like communication between
> coordinators and the catalogd may need a larger value.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
