[
https://issues.apache.org/jira/browse/IMPALA-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632565#comment-17632565
]
ASF subversion and git services commented on IMPALA-11537:
----------------------------------------------------------
Commit 97a506c6560e7a0c6c5ba7d098f07c6b04ef6cad in impala's branch
refs/heads/master from Peter Rozsa
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=97a506c65 ]
IMPALA-11537: Query option validation for numeric types
This change adds a more generic approach to validate numeric
query options and report parse and validation errors.
Supported types: integers, floats, memory specifications.
Range and bound validator helper functions are added to make
validation unified on call sites.
Testing:
- Error messages got more generic, therefore the existing tests
around query options are aligned to match them
Change-Id: Ia7757b52393c094d2c661918d73cbfad7214f855
Reviewed-on: http://gerrit.cloudera.org:8080/19096
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Some Query Options are not validated
> ------------------------------------
>
> Key: IMPALA-11537
> URL: https://issues.apache.org/jira/browse/IMPALA-11537
> Project: IMPALA
> Issue Type: Bug
> Reporter: Noemi Pap-Takacs
> Assignee: Peter Rozsa
> Priority: Minor
> Labels: newbie, ramp-up
>
> Query Options can be set in the Impala shell, but they are not validated
> immediately.
> Most Query Options require integer values. The input is parsed in
> be/src/service/query-options.cc. There are many different solutions how these
> integers are parsed. Some older implementations use atoi(), the newer ones
> mostly use StringParser.
> The older Query Options that use atoi() does not validate the input value.
> The atoi() function may not be able to parse the input, so either the query
> gets executed using the default value for the given Query Option, without
> informing the user about it, or it can even cause undefined behavior.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
