[
https://issues.apache.org/jira/browse/IMPALA-10871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642626#comment-17642626
]
Michael Smith commented on IMPALA-10871:
----------------------------------------
The patch for this looks incorrect.
https://gerrit.cloudera.org/c/17774/18/fe/pom.xml#1062 doesn't actually get
replaced by an environment variable because it's not enclosed in
{code}${...}{code}.
> Add MetastoreShim to support Apache Hive 3.x
> --------------------------------------------
>
> Key: IMPALA-10871
> URL: https://issues.apache.org/jira/browse/IMPALA-10871
> Project: IMPALA
> Issue Type: Task
> Reporter: Quanlong Huang
> Assignee: Fucun Chu
> Priority: Major
>
> Impala 3.x supports both Hive 2 and 3 by a MetastoreShim that is chose at
> compilation time:
> {code:bash}
> fe/src/compat-hive-2
> └── java/org/apache
> ├── hadoop/hive/common/ValidWriteIdList.java
> └── impala/compat/MetastoreShim.java
> fe/src/compat-hive-3
> └── java/org/apache/impala/compat
> ├── HiveMetadataFormatUtils.java
> └── MetastoreShim.java {code}
> In pom.xml:
> {code:xml}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>build-helper-maven-plugin</artifactId>
> <version>1.5</version>
> <executions>
> <!-- Tell maven about our generated files -->
> <execution>
> <id>add-source</id>
> <phase>generate-sources</phase>
> <goals>
> <goal>add-source</goal>
> </goals>
> <configuration>
> <sources>
> ...
>
> <source>${project.basedir}/src/compat-hive-${hive.major.version}/java</source>
> </sources>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
> Now MetastoreShim evolves to only support CDP Hive which contains some
> breaking changes of Hive 4.x.
> To support Apache Hive 3.x, we need another MetastoreShim. Some codes that
> directly use Hive 4 APIs may need to be ignored in compilation, e.g.
> fe/src/main/java/org/apache/impala/catalog/metastore/*.java
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
