[ 
https://issues.apache.org/jira/browse/IMPALA-10854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649930#comment-17649930
 ] 

Joe McDonnell commented on IMPALA-10854:
----------------------------------------

Fixed by 
[https://github.com/cloudera/native-toolchain/commit/4c9d86b9ab2518ed775c260cad375dd7529e553b]
{noformat}
IMPALA-10854: Use ZSTD in toolchain to build ORC

The ORC build will download and compile ZSTD if env var ZSTD_HOME is
undefined. We already have ZSTD in the toolchain. This patch let ORC
depends on the ZSTD in our toolchain. Also disables building ORC tests.

Tests:
 - Built native-toolchain and verified check/orc-1.7.0-p7.log that zstd
   is not downloaded again.
 - Compiled Impala with it and ran TPCH tests locally.
Change-Id: Ifa8f0f55254e777b0132480a80737d9169410c73

Reviewed-on: http://gerrit.cloudera.org:8080/18367
Reviewed-by: Wenzhe Zhou <[email protected]>
Reviewed-by: Csaba Ringhofer <[email protected]>
Tested-by: Quanlong Huang <[email protected]>{noformat}

> Consider depending on toolchain's ZSTD while building ORC in native-toolchain
> -----------------------------------------------------------------------------
>
>                 Key: IMPALA-10854
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10854
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>            Reporter: Quanlong Huang
>            Assignee: Quanlong Huang
>            Priority: Major
>
> While building orc-1.6.2-p* in native-toolchain, it downloads zstd-1.3.5 from 
> [https://github.com/facebook/zstd/archive/v1.3.5.tar.gz] 
> We already have zstd-1.4.9 in native-toolchain. We should consider using it 
> instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to