[ 
https://issues.apache.org/jira/browse/IMPALA-11869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Becker updated IMPALA-11869:
-----------------------------------
    Description: 
The change_ IMPALA-11645: Remove PrintThriftEnum functions in debug-utils.cc_ 
introduced the function {{PrintValue()}} which we use to convert Thrift types 
to strings. This function now uses {{operator<<}}, which is provided for the 
generated thrift types. However, Thrift also generates a {{to_string()}} 
function that is overloaded for Thrift types. It would be more efficient to use 
this instead of involving streams with {{operator<<}}.


  was:
The change_ IMPALA-11645: Remove PrintThriftEnum functions in debug-utils.cc_ 
introduced the function {{PrintValue()}} which we use to convert Thrift types 
to strings. This function now uses {{operator<<}}, which is provided for the 
generated thrift types. However, Thrift also generates a {{to_string() }} 
function that is overloaded for Thrift types. It would be more efficient to use 
this instead of involving streams with {{operator<<}}.



> Use to_string() in PrintValue for printing thrift types
> -------------------------------------------------------
>
>                 Key: IMPALA-11869
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11869
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>            Reporter: Daniel Becker
>            Assignee: Daniel Becker
>            Priority: Minor
>
> The change_ IMPALA-11645: Remove PrintThriftEnum functions in debug-utils.cc_ 
> introduced the function {{PrintValue()}} which we use to convert Thrift types 
> to strings. This function now uses {{operator<<}}, which is provided for the 
> generated thrift types. However, Thrift also generates a {{to_string()}} 
> function that is overloaded for Thrift types. It would be more efficient to 
> use this instead of involving streams with {{operator<<}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to