[
https://issues.apache.org/jira/browse/IMPALA-11927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691881#comment-17691881
]
Quanlong Huang commented on IMPALA-11927:
-----------------------------------------
Attached the FlameGraphs of TPCH-Q19. They are captured on impala that compiles
with two different snappy libs, i.e. with and without frame pointers.
With the old snappy lib, the majority of
impala::HdfsParquetScanner::AssembleRows<false> is
impala::HdfsParquetScanner::FillScratchMicroBatches
!AssembleRows-without-frame-pointer.png|width=956,height=356!
With the new snappy lib, the portion of
impala::HdfsParquetScanner::SkipRowsForColumns() in AssembleRows() now makes
more sense:
!AssembleRows-with-frame-pointer.png|width=955,height=378!
> Build snappy and lz4 with no-omit-frame-pointer flag
> ----------------------------------------------------
>
> Key: IMPALA-11927
> URL: https://issues.apache.org/jira/browse/IMPALA-11927
> Project: IMPALA
> Issue Type: Sub-task
> Components: Infrastructure
> Reporter: Quanlong Huang
> Assignee: Quanlong Huang
> Priority: Major
> Attachments: AssembleRows-with-frame-pointer.png,
> AssembleRows-without-frame-pointer.png, has-frame-pointer-tpch-q19.svg,
> no-frame-pointer-tpch-q19.svg
>
>
> Snappy and Lz4 compression/decompression are used in many different code
> paths. As a subtask of IMPALA-10917, add the no-omit-frame-pointer flag for
> them first and measure the perf impact.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
