[
https://issues.apache.org/jira/browse/IMPALA-11645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691988#comment-17691988
]
ASF subversion and git services commented on IMPALA-11645:
----------------------------------------------------------
Commit 88a7538af79afc19233cdfe3220e3c25e7edd16d in impala's branch
refs/heads/master from Daniel Becker
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=88a7538af ]
IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
IMPALA-11645 introduced the function PrintValue() which we use to
convert Thrift types to strings. This function used operator<<,
which is provided for the generated Thrift types. However, Thrift also
generates a to_string() function that is overloaded for Thrift types. It
would be more efficient to use this instead of involving streams with
operator<<.
This change reimplements PrintValue() using to_string() instead of
operator<<.
Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Reviewed-on: http://gerrit.cloudera.org:8080/19487
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Remove PrintThriftEnum functions in debug-utils.cc
> --------------------------------------------------
>
> Key: IMPALA-11645
> URL: https://issues.apache.org/jira/browse/IMPALA-11645
> Project: IMPALA
> Issue Type: Improvement
> Reporter: Daniel Becker
> Assignee: Daniel Becker
> Priority: Major
>
> Before IMPALA-5690 we implemented operator<< for Thrift enums in Impala code.
> These functions printed the names of the enums.
> Then we upgraded to Thrift 0.9.3, but that release included THRIFT-2067,
> which implemented operator<< for Thrift enums, but printed the number value
> of enums instead of their names. To preserve the old behaviour in Impala, we
> renamed our own implementations of operator<< to PrintThriftEnum, a function
> that we defined for each Thrift enum we used, and which returned a string
> with the names - not the numbers - of the enums.
> After upgrading Thrift to a version that included THRIFT-3921 (any version
> starting from 0.11.0), these PrintThriftEnum functions are no longer
> necessary as the operator<< provided by Thrift now prints the names of enums,
> which is the behaviour we want.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
